Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: any status codes are allowed #2

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Fix: any status codes are allowed #2

merged 5 commits into from
Jan 27, 2025

Conversation

Furrior
Copy link
Contributor

@Furrior Furrior commented Jan 27, 2025

Summary by Sourcery

Tests:

  • Add tests for HTTP requests.

@Furrior Furrior requested a review from Gaxeer January 27, 2025 20:54
Copy link

sourcery-ai bot commented Jan 27, 2025

Reviewer's Guide by Sourcery

This pull request modifies the http client to allow any status code to be returned, adds a timeout to the http client, and adds a new http test.

Sequence diagram for modified HTTP request handling

sequenceDiagram
    participant Client
    participant HTTPClient
    participant Server

    Client->>HTTPClient: Send HTTP request
    Note over HTTPClient: Set 30s timeout
    HTTPClient->>Server: Forward request
    Server-->>HTTPClient: Response (any status code)
    Note over HTTPClient: Allow any status code
    HTTPClient-->>Client: Return response
Loading

Class diagram showing error handling changes

classDiagram
    class Error {
        +JsonSerialization
        +Response
    }
    class RequestPrep {
        +req
        +body
    }
    note for Error "Changed Request to Response error type"
    Error *-- RequestPrep
Loading

File-Level Changes

Change Details Files
The http client now allows any status code to be returned.
  • The or_any_status method was added to the send_bytes call.
src/http.rs
A timeout was added to the http client.
  • The timeout method was added to the request builder.
src/http.rs
A new http test was added.
  • The http test function was added to tests/dm-tests.rs.
  • The http.dme test file was added.
tests/dm-tests.rs
tests/dm/http.dme
The error type for http requests was changed.
  • The Request error type was changed to Response.
src/error.rs
New constants were added for http job results.
  • The RUSTUTILS_JOB_NO_RESULTS_YET, RUSTUTILS_JOB_NO_SUCH_JOB, and RUSTUTILS_JOB_ERROR constants were added.
dmsrc/http.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine.

@Furrior Furrior merged commit c504fe2 into master Jan 27, 2025
2 checks passed
@Furrior Furrior deleted the statusfix branch January 27, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant