Adjust modular space ruins with new loot system + minor tweaks

[kyunkyunkyun]

Что этот PR делает

Добавляет оффовские спавнеры лута в модульные руины.
Добавляет несколько новых, модульных спавнеров для определённых руин.
Добавляет тиреи на те наши руины, где присутствуют сейфы с лутом, чтобы это было более очевидно для гейтеров и им не приходилось лезть в код чтобы найти заветный сейф, который иначе никак не обнаружить.
Слегка передвигает одного из воксов на руине voxraiders_1 и добавляет ему стеклянный аирлок, чтобы он не игнорировал лутающегося рядом гейтера.

Почему это хорошо для игры

Больше рандома = больше реиграбельности.

Пока без гейтов, но если всё норм, то гейты тоже можно будет зааджастить позднее, как уже частично произошло со спейсбаттлом.

Тестирование

Поюзал все спавнеры на локалке, без проблем, вроде. Наверное, стоит юзать в ТМе, пока не замержат #1764

Changelog

🆑
tweak: Модульные руины обновлены в соответствии с недавним ребалансом лута космоса с оффов.
/:cl:

Summary by Sourcery

Update modular space ruins with the new loot system.

New Features:

• Added off-station loot spawners to modular space ruins.
• Added new modular spawners for specific ruins.

Tests:

• Tested all spawners locally.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new loot system to modular space ruins, enhancing their replayability. It also includes minor tweaks to existing ruins, such as adding tiers to loot safes and adjusting the position of a Vox.

Class diagram for new loot spawner system

classDiagram
    class SpawnPool {
      +available_points: int
    }
    class SpaceLoot {
      +available_points: 2200
    }
    class RandomPoolSpawner {
      +point_value: int
      +spawn_loot_chance: int
      +loot: list
    }

    SpawnPool <|-- SpaceLoot
    RandomPoolSpawner <|-- MechTransportMecha
    RandomPoolSpawner <|-- MechTransportEquipment
    RandomPoolSpawner <|-- ModsuitSyndie
    RandomPoolSpawner <|-- LaserSpawner
    RandomPoolSpawner <|-- MiningToolSpawner
    RandomPoolSpawner <|-- SecurityModsuitSpawner

    class MechTransportMecha {
      +point_value: 100
      +loot: DurandOld
    }
    class MechTransportEquipment {
      +point_value: 40
      +spawn_all_loot: true
    }
    class ModsuitSyndie {
      +point_value: 110
      +spawn_loot_chance: 30
    }
    class LaserSpawner {
      +point_value: 30
      +spawn_loot_chance: 40
    }
    class SecurityModsuitSpawner {
      +point_value: 75
      +spawn_loot_chance: 45
    }

    note for SpaceLoot "New space loot pool system"

Loading

File-Level Changes

Change	Details	Files
Added off-station loot spawners to modular ruins.	Created a new spaceloot spawn pool. Added several new loot spawners to the spaceloot pool, including mecha, weapons, and modsuits. Added new suit storage units for security modsuits.	modular_ss220/balance/code/loot/pools.dm modular_ss220/objects/code/suit_storage_unit.dm modular_ss220/objects/_objects.dme
Added new modular spawners for specific ruins.	Created a new spawner for the mechtransport_new ruin. Added a spawner for mecha equipment.	modular_ss220/balance/code/loot/pools.dm
Added tiers to ruins with loot safes.	Added a tier system to make loot safes more obvious to players.	modular_ss220/maps220/code/RandomRuins/space/space_ruins.dm
Adjusted the position of a Vox on the voxraiders_1 ruin and added a glass airlock.	Moved a Vox to prevent it from ignoring nearby players. Added a glass airlock to the Vox's location.	_maps/map_files220/RandomRuins/SpaceRuins/voxraiders_1.dmm
Added a new mech to the game.	Added a new mech, mechtransport_new, to the game.	modular_ss220/objects/code/mecha/combat.dm
Updated several map files.	Updated map files to include new loot spawners and tier system.	_maps/map_files220/RandomRuins/SpaceRuins/convoy_ambush.dmm _maps/map_files220/RandomRuins/SpaceRuins/destroyed_infiltrator.dmm _maps/map_files220/RandomRuins/SpaceRuins/infected_ship.dmm _maps/map_files220/RandomRuins/SpaceRuins/mechtransport_new.dmm _maps/map_files220/RandomRuins/SpaceRuins/sierra_1_4.dmm _maps/map_files220/RandomRuins/SpaceRuins/spacehotel.dmm _maps/map_files220/RandomRuins/SpaceRuins/transit_bar.dmm

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[m-dzianishchyts]

Вроде норм, но не понял, зачем это в отеле

[kyunkyunkyun]

Вроде норм, но не понял, зачем это в отеле

вообще я написал зачем, но подумав понял, что идея хуйня и лучше делать записки, наводящие на сейф в руине, а не кидать какой-то рандомный тирей. я пока перемещу его в комнату с сейфом, как "тонкий" намёк, а записки делать не буду.. может у нас появится лоровед, который этим займётся