Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space loot fix #1763

Closed
wants to merge 1 commit into from
Closed

Conversation

kyunkyunkyun
Copy link

@kyunkyunkyun kyunkyunkyun commented Jan 24, 2025

Что этот PR делает

позволяет гейтерам манчиться в космосе, чиня спавнер лута.
соответствующая ищью висит в дискорде
удаляет строчку кода, добавленную Максимом при мерже апстрима. Она всё портит!

Почему это хорошо для игры

фикс

Тестирование

локалка загрузилась, но наверное лучше ТМом делать.

Changelog

🆑
fix: Лут в космосе снова спавнится.
/:cl:

Summary by Sourcery

Bug Fixes:

  • Fix loot not spawning in space after a recent merge.

Copy link

sourcery-ai bot commented Jan 24, 2025

Reviewer's Guide by Sourcery

This pull request fixes an issue where loot was not spawning in space by removing a line of code that was causing the issue. The change also allows for the addition of new spawners.

Sequence diagram for loot spawner initialization

sequenceDiagram
    participant S as Spawner
    participant P as Pool Manager
    participant SP as Spawn Pool
    S->>P: Initialize
    P->>SP: get(spawn_pool_id)
    S->>SP: Add to guaranteed_spawners/known_spawners
    Note right of S: No longer self-deletes
    S->>S: Continue existing
Loading

Class diagram for spawner relationship

classDiagram
    class SpawnPoolManager {
        +get(spawn_pool_id)
    }
    class SpawnPool {
        +guaranteed_spawners
        +known_spawners
    }
    class Spawner {
        +spawn_pool_id
        +generate_loot_list()
        +Initialize()
    }
    SpawnPoolManager --> SpawnPool : manages
    SpawnPool --> Spawner : contains
    note for Spawner "Removed INITIALIZE_HINT_QDEL"
Loading

File-Level Changes

Change Details Files
Removed a line of code that was preventing loot from spawning.
  • Removed the line return INITIALIZE_HINT_QDEL from the register_spawner function in pool_spawner.dm
code/game/objects/effects/spawners/random/pool/pool_spawner.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@kyunkyunkyun kyunkyunkyun changed the title rrr Space loot fix Jan 24, 2025
@github-actions github-actions bot added 🔧 Фикс Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах :finnadie: НЕ МОДУЛЬНО Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим. labels Jan 24, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 24, 2025
@m-dzianishchyts
Copy link
Collaborator

Ну да, проблема будет в этом, но чинится не совсем так, занимаюсь этим сейчас

@kyunkyunkyun kyunkyunkyun deleted the space-loot-fix branch January 24, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:finnadie: НЕ МОДУЛЬНО Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим. 📜 CL валиден Этот чейнджлог будет успешно опубликован 🔧 Фикс Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants