forked from ParadiseSS13/Paradise
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space loot fix #1763
Closed
Closed
Space loot fix #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request fixes an issue where loot was not spawning in space by removing a line of code that was causing the issue. The change also allows for the addition of new spawners. Sequence diagram for loot spawner initializationsequenceDiagram
participant S as Spawner
participant P as Pool Manager
participant SP as Spawn Pool
S->>P: Initialize
P->>SP: get(spawn_pool_id)
S->>SP: Add to guaranteed_spawners/known_spawners
Note right of S: No longer self-deletes
S->>S: Continue existing
Class diagram for spawner relationshipclassDiagram
class SpawnPoolManager {
+get(spawn_pool_id)
}
class SpawnPool {
+guaranteed_spawners
+known_spawners
}
class Spawner {
+spawn_pool_id
+generate_loot_list()
+Initialize()
}
SpawnPoolManager --> SpawnPool : manages
SpawnPool --> Spawner : contains
note for Spawner "Removed INITIALIZE_HINT_QDEL"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![:finnadie: :finnadie:](https://github.githubassets.com/images/icons/emoji/finnadie.png)
Ну да, проблема будет в этом, но чинится не совсем так, занимаюсь этим сейчас |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
![:finnadie: :finnadie:](https://github.githubassets.com/images/icons/emoji/finnadie.png)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
позволяет гейтерам манчиться в космосе, чиня спавнер лута.
соответствующая ищью висит в дискорде
удаляет строчку кода, добавленную Максимом при мерже апстрима. Она всё портит!
Почему это хорошо для игры
фикс
Тестирование
локалка загрузилась, но наверное лучше ТМом делать.
Changelog
🆑
fix: Лут в космосе снова спавнится.
/:cl:
Summary by Sourcery
Bug Fixes: