Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM] Fix player kicking #1752

Closed

Conversation

m-dzianishchyts
Copy link
Collaborator

@m-dzianishchyts m-dzianishchyts commented Jan 19, 2025

Что этот PR делает

Возвращает возможность бьендовского кика, путем удаления клиента, который сломался после отключения харддела.

Тестирование

Удалил себя на локалке.

Summary by Sourcery

Bug Fixes:

  • Fixed player kicking being broken after hard deletion was disabled.

@m-dzianishchyts m-dzianishchyts added 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать Testmerge Required labels Jan 19, 2025
Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request re-enables player kicking by removing the hard deletion of clients. This change was made to address a bug introduced after disabling hard deletes for performance reasons.

Sequence diagram for player kicking process

sequenceDiagram
    actor Admin
    participant Server
    participant Client
    participant GarbageCollector

    Admin->>Server: Initiates kick command
    Server->>GarbageCollector: Request client deletion
    GarbageCollector->>Client: Hard delete client (del)
    Note over Client: Client connection terminated
    GarbageCollector-->>Server: Client removed
Loading

File-Level Changes

Change Details Files
Re-enable player kicking by removing the hard deletion of clients.
  • Added a conditional check to only delete clients.
  • Re-enabled the deletion of clients.
code/controllers/subsystem/SSgarbage.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added 🔧 Фикс Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах :finnadie: НЕ МОДУЛЬНО Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим. labels Jan 19, 2025
@m-dzianishchyts m-dzianishchyts added 🕛 Ждёт мержа Совсем скоро это будет залито and removed Testmerge Required labels Jan 23, 2025
@m-dzianishchyts m-dzianishchyts changed the title Fix player kicking [TM] Fix player kicking Jan 25, 2025
@github-actions github-actions bot added the Merge Conflict Ну блять... label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕛 Ждёт мержа Совсем скоро это будет залито :finnadie: НЕ МОДУЛЬНО Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим. Merge Conflict Ну блять... 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать 🔧 Фикс Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant