Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Добавляет таярам новый эмоут - короткое мурчание #1751

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

HNSakt
Copy link

@HNSakt HNSakt commented Jan 17, 2025

Что этот PR делает

Добавляет таярам новое мурчание , короткое мурчание портированное с ТГ нашего.

Почему это хорошо для игры

Больше расовых эмоутов = лучше.

Изображения изменений

Тестирование

Зашел на локалку и мурчал , вроде ничего не взорвалось и никто не умер.

Changelog

🆑 Hans
add: Портировал с ТГ короткое мурчание для таяр.
soundadd: Портировал с ТГ звук короткого мурчания.
/:cl:

Summary by Sourcery

New Features:

  • Added a new short purr emote for the Tajara species.

Copy link

sourcery-ai bot commented Jan 17, 2025

Reviewer's Guide by Sourcery

This pull request adds a new short purr emote for the Tajaran species. The emote includes a new sound and is added to the Tajaran's available emotes.

Sequence diagram for Tajaran short purr emote execution

sequenceDiagram
    actor Player
    participant Human as Human Mob
    participant Emote as Emote System
    participant Sound as Sound System

    Player->>Human: Triggers 'mrowss' emote
    Human->>Emote: emote('mrowss', intentional=TRUE)
    Note over Emote: Checks species whitelist
    Note over Emote: Validates cooldown
    Emote->>Sound: Play 'mrowss.ogg'
    Emote-->>Human: Display purr message
    Human-->>Player: See/hear purr emote
Loading

Class diagram showing the new emote structure

classDiagram
    class datum_emote_living_carbon_human_mrowss {
      +key: string
      +key_third_person: string
      +message: string
      +message_param: string
      +sound: string
      +species_type_whitelist_typecache: list
      +emote_type: int
      +vary: bool
      +cooldown: int
      +volume: int
      +muzzled_noises: list
    }
    class mob_living_carbon_human {
      +emote_mrowss()
    }
    class datum_species_tajaran {
      +on_species_gain(mob/living/carbon/human/H)
      +on_species_loss(mob/living/carbon/human/H)
    }
    mob_living_carbon_human -- datum_emote_living_carbon_human_mrowss : uses
    datum_species_tajaran -- mob_living_carbon_human : manages emotes
Loading

File-Level Changes

Change Details Files
Added a new emote 'mrowss' for Tajara.
  • Defined a new /datum/emote/living/carbon/human/mrowss with a key, message, sound, species whitelist, emote type, cooldown, and volume.
  • Added 'mrowss' to the list of muzzled noises.
modular_ss220/emotes/code/emote.dm
Added a new verb for the 'mrowss' emote.
  • Added a new /mob/living/carbon/human/proc/emote_mrowss verb that calls the 'mrowss' emote.
modular_ss220/emotes/code/emote_verbs.dm
Added the new 'mrowss' verb to the Tajaran species.
  • Added the /mob/living/carbon/human/proc/emote_mrowss verb to the Tajaran species on species gain.
  • Removed the /mob/living/carbon/human/proc/emote_mrowss verb from the Tajaran species on species loss.
modular_ss220/emotes/code/racial_emotes.dm
Added a new define for the 'mrowss' emote.
  • Added a new define EMOTE_HUMAN_MROWSS with the value 'Мурчать коротко'.
modular_ss220/_defines220/code/emote.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🔉 Звук Услада для ушей. label Jan 17, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 17, 2025
@Gaxeer Gaxeer merged commit 4951a62 into ss220club:master Jan 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован 🔉 Звук Услада для ушей.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants