forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time display #1114
Merged
Merged
Fix time display #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request fixes the way round and lobby time are displayed by ensuring the correct time is shown. Sequence diagram for time display calculationsequenceDiagram
participant Client
participant StatPanel
participant GameTimestamp
participant TimeHelpers
Client->>StatPanel: Request time display
StatPanel->>GameTimestamp: gameTimestamp(STATION_TIME_PASSED(), timezone=0)
GameTimestamp->>TimeHelpers: time2text(wtime, format, timezone)
TimeHelpers-->>GameTimestamp: Formatted time string
GameTimestamp-->>StatPanel: Time string
StatPanel-->>Client: Display time with timezone adjustment
Class diagram for time-related functionsclassDiagram
class TimeHelpers {
+time2text(timeofday, format)
+gameTimestamp(format, wtime, timezone)
+station_time(display_only, wtime)
}
class StatPanels {
+initialize()
+update_time_display()
}
note for TimeHelpers "Modified gameTimestamp to include timezone parameter"
StatPanels --> TimeHelpers: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
dj-34
reviewed
Jan 31, 2025
Co-authored-by: dj-34 <dj-34@bk.ru>
Co-authored-by: dj-34 <dj-34@bk.ru>
dj-34
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Round time и lobby time теперь показывают время правильно
Тестирование
Запустил, проверил
Changelog
🆑
fix: Round time и lobby time теперь показывают время правильно
/:cl:
Summary by Sourcery
Bug Fixes: