Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head dismembering is back, craial fissure is now can only be caused by blunt damage #1038

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Gaxeer
Copy link
Collaborator

@Gaxeer Gaxeer commented Jan 21, 2025

Что этот PR делает

Возвращает отрубание головы для всех типов голов просто уроном
Травма "трещина черепа" (cranial fissure) теперь может быть вызвана только тупым уроном

closes #1025

Почему это хорошо для игры

Отрубание головы это весело и было отлючено для всех кроме зомби просто потому что

Изображения изменений

Ужасные картинки с молью

image
image

Тестирование

В изображениях всё есть :jokerge:

Changelog

🆑
balance: Возвращает отрубание головы нанесением урона
balance: Травма "трещина черепа" (cranial fissure) теперь может быть вызвана только уроном тупыми предметами
/:cl:

Summary by Sourcery

Re-enable head dismemberment for all head types by damage and restrict cranial fissure trauma to blunt damage only.

New Features:

  • Re-enabled head dismemberment for all creature types.

Tests:

  • Changes verified visually.

Copy link

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request re-enables head dismemberment for all head types via damage and restricts cranial fissure wounds to only be caused by blunt damage.

Class diagram showing modified head and wound classes

classDiagram
    class obj_item_bodypart_head {
        +bool can_dismember
    }
    note for obj_item_bodypart_head "Modified to enable dismemberment"

    class datum_wound_pregen_data_cranial_fissure {
        +list required_wounding_types
    }
    note for datum_wound_pregen_data_cranial_fissure "Restricted to WOUND_BLUNT only"
Loading

State diagram for head dismemberment and cranial fissure conditions

stateDiagram-v2
    [*] --> Head
    Head --> DismemberedHead: Any damage type
    Head --> CranialFissure: Only blunt damage
    CranialFissure --> DismemberedHead: Sufficient damage
    DismemberedHead --> [*]

    note right of Head
        All head types can now be dismembered
    end note

    note right of CranialFissure
        Restricted to blunt damage only
    end note
Loading

File-Level Changes

Change Details Files
Re-enabled head dismemberment for all head types.
  • Added a new file that sets the can_dismember variable to TRUE for all heads.
modular_bandastation/balance/code/bodyparts/head.dm
Restricted cranial fissure wounds to only be caused by blunt damage.
  • Added a new file that sets the required_wounding_types variable to only include WOUND_BLUNT for cranial fissure wounds.
modular_bandastation/balance/code/wounds/cranial_fissure.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 21, 2025
@Gaxeer Gaxeer merged commit d40fbf2 into ss220club:master Jan 21, 2025
31 of 33 checks passed
ss220app bot added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Вернуть дисмембер головы
3 participants