forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Honorbound religion obtainability from Altar #1037
Merged
Gaxeer
merged 4 commits into
ss220club:master
from
dj-34:remove_honorbound_religious_sect
Jan 21, 2025
Merged
Remove Honorbound religion obtainability from Altar #1037
Gaxeer
merged 4 commits into
ss220club:master
from
dj-34:remove_honorbound_religious_sect
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request removes the Honorbound religion from the list of religions that can be obtained at the Altar. This was done to address a valid hunt exploit. Class diagram showing the religion_sect class modificationclassDiagram
class religion_sect {
+bool obtainable
}
class honorbound {
-bool obtainable
}
religion_sect <|-- honorbound
note for religion_sect "Added new obtainable flag"
note for honorbound "Sets obtainable to false"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
dj-34
added
❓ Под вопросом
Есть сомнения по этому ПРу.
and removed
📜 CL валиден
Этот чейнджлог будет успешно опубликован
labels
Jan 21, 2025
larentoun
reviewed
Jan 21, 2025
larentoun
reviewed
Jan 21, 2025
Gaxeer
reviewed
Jan 21, 2025
Gaxeer
added
the
🛑 Do Not Merge
Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это!
label
Jan 21, 2025
Временно не мержим. На религии есть механические ограничения. Надо обсудить. |
Gaxeer
removed
the
🛑 Do Not Merge
Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это!
label
Jan 21, 2025
Gaxeer
reviewed
Jan 21, 2025
Gaxeer
approved these changes
Jan 21, 2025
Co-authored-by: larentoun <31931237+larentoun@users.noreply.github.com>
dj-34
force-pushed
the
remove_honorbound_religious_sect
branch
from
January 21, 2025 18:21
f5ee3b5
to
c5299cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
closes #1033
Удаляет религию Honorbound из списка возможных для приобретения на Алтаре.
Почему это хорошо для игры
Реквест на удаление от Шусса по причине легит валидханта от священника и его приспешников.
Изображения изменений
Тестирование
Проверял на локалке.
Changelog
🆑
balance: Религия Honorbound более недоступна для приобретения на Алтаре священника.
/:cl:
Summary by Sourcery
Tests: