Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Honorbound religion obtainability from Altar #1037

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

dj-34
Copy link
Collaborator

@dj-34 dj-34 commented Jan 21, 2025

Что этот PR делает

closes #1033
Удаляет религию Honorbound из списка возможных для приобретения на Алтаре.

Почему это хорошо для игры

Реквест на удаление от Шусса по причине легит валидханта от священника и его приспешников.

Изображения изменений

image

Тестирование

Проверял на локалке.

Changelog

🆑
balance: Религия Honorbound более недоступна для приобретения на Алтаре священника.
/:cl:

Summary by Sourcery

Tests:

  • Tested locally.

Copy link

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request removes the Honorbound religion from the list of religions that can be obtained at the Altar. This was done to address a valid hunt exploit.

Class diagram showing the religion_sect class modification

classDiagram
    class religion_sect {
        +bool obtainable
    }
    class honorbound {
        -bool obtainable
    }
    religion_sect <|-- honorbound
    note for religion_sect "Added new obtainable flag"
    note for honorbound "Sets obtainable to false"
Loading

File-Level Changes

Change Details Files
Added a check to determine if a religion can be obtained at the Altar.
  • Added a check to the sects_to_pick list to only add religions that are obtainable.
code/datums/components/religious_tool.dm
Added a new obtainable variable to the religion_sect datum.
  • Added a new obtainable variable to the religion_sect datum, defaulting to TRUE.
  • Set the obtainable variable to FALSE for the Honorbound religion.
modular_bandastation/balance/code/religion.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 21, 2025
@dj-34 dj-34 added ❓ Под вопросом Есть сомнения по этому ПРу. and removed 📜 CL валиден Этот чейнджлог будет успешно опубликован labels Jan 21, 2025
@dj-34 dj-34 marked this pull request as draft January 21, 2025 00:56
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 21, 2025
@m-dzianishchyts
Copy link

image

@m-dzianishchyts m-dzianishchyts removed the ❓ Под вопросом Есть сомнения по этому ПРу. label Jan 21, 2025
@dj-34 dj-34 marked this pull request as ready for review January 21, 2025 01:30
@Gaxeer Gaxeer added the 🛑 Do Not Merge Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это! label Jan 21, 2025
@Gaxeer
Copy link
Collaborator

Gaxeer commented Jan 21, 2025

Временно не мержим. На религии есть механические ограничения. Надо обсудить.

@Gaxeer Gaxeer removed the 🛑 Do Not Merge Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это! label Jan 21, 2025
@dj-34 dj-34 force-pushed the remove_honorbound_religious_sect branch from f5ee3b5 to c5299cd Compare January 21, 2025 18:21
@Gaxeer Gaxeer merged commit 348bd70 into ss220club:master Jan 21, 2025
22 of 24 checks passed
ss220app bot added a commit that referenced this pull request Jan 21, 2025
@Lime-7
Copy link

Lime-7 commented Jan 21, 2025

image

@dj-34 dj-34 deleted the remove_honorbound_religious_sect branch January 21, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Запрос с Прайма] Вырезать религию крестоносца у сятоши
5 participants