Upstream species fix

[Nlaysi]

Что этот PR делает

Исправления под расы (сломали раскраску тела на апстриме)

Changelog

🆑
fix: Исправление закрашивания аксессуаров раскраски тела
/:cl:

Summary by Sourcery

Bug Fixes:

• Fix incorrect coloring of vulpkanin body markings.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue where Vulpkanin body markings were not being colored correctly. It also adds a new proc to update body markings.

Sequence diagram for Vulpkanin body marking update process

sequenceDiagram
    participant S as Species
    participant BO as BodypartOverlay
    participant SA as SpriteAccessory

    S->>S: update_body_markings(hooman)
    Note over S: Check if update needed
    alt needs update
        S->>S: remove_body_markings(hooman)
        S->>S: add_body_markings(hooman)
        S->>BO: set_appearance(name, color, bodypart)
        BO->>SA: get_accessory(name)
        SA-->>BO: return accessory
        Note over BO: Update colors and icons
    end

Loading

Class diagram for updated Vulpkanin body marking classes

classDiagram
    class BodypartOverlaySimpleBodyMarkingVulpkanin {
      +set_appearance(name, set_color, bodypart)
      +generate_icon_cache()
      +can_draw_on_bodypart(human)
      +aux_color_paw
      +draw_color
    }

    class SpriteAccessoryVulpkaninBodyMarkings {
      +icon
      +name
      +colored_paws
      +color_src
      +gender_specific
    }

    class Species {
      +update_body_markings(hooman)
      +remove_body_markings(hooman)
      +add_body_markings(hooman)
    }

    BodypartOverlaySimpleBodyMarkingVulpkanin --> SpriteAccessoryVulpkaninBodyMarkings
    Species --> BodypartOverlaySimpleBodyMarkingVulpkanin : uses

Loading

File-Level Changes

Change	Details	Files
Added a new proc to update body markings.	Added a new proc update_body_markings to update body markings. Added a call to update_body_markings in apply_overlay.	code/modules/mob/living/carbon/human/_species.dm
Fixed an issue where Vulpkanin body markings were not being colored correctly.	Added a new proc set_appearance to set the appearance of the body marking. Added a new proc generate_icon_cache to generate the icon cache. Added a new proc can_draw_on_bodypart to check if the body marking can be drawn on the body part. Modified add_body_markings to use the new set_appearance proc.	modular_bandastation/species/code/human/sprite_accessories/vulpkanin.dm modular_bandastation/species/code/human/species_type/vulpkanin.dm

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[PhantornRU]

ТМ запрошен?

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself