Add stan setting to output static analysis report
#384
Conversation
|
I'd also make one of the tests use this setting so |
|
From the test logs:
And the HTML report is in the |
| Run **ST**atic **AN**alysis on the package using [stan] and generate an HTML report. The report is created in the `/nix/store` path alongside your package outputs. | ||
|
|
||
| > [!note] stan configuration | ||
| > This setting looks for a `.stan.toml` file in the root of the package source. See a sample [.stan.toml] configuration for reference. |
There was a problem hiding this comment.
A bit of hardcoding here. I guess we could eliminate this by making the stan setting a submodule (providing an option to configure custom configuration path) instead of just a boolean, but I doubt that’s necessary.
There was a problem hiding this comment.
I followed these instructions and added .stan.toml to the root:
However, it doesn't seem to be used, because the generated report still doesn't exclude the StrictData suggestion:
It'd be good to demonstrate this in a sample repo, like https://github.com/srid/haskell-template - along with .stan.toml.
|
@shivaraj-bh Do we also use the HLS integration? |
|
Trying this on vira project I hit kowainik/stan#392 ... I wonder if this happens on internal projects too. EDIT: Happens on haskell-template too: srid/haskell-template#147 |
|
Another thing worth considering: add a flake check that will fail if project health is not 100%. Poeple can always add excludes to their stan config if there's a good reason to reject certain suggestions. |
No |
Generating this report is just: