fix: overrides config with cli options on compiler #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
Oct 18, 2024
borkdude
reviewed
Oct 19, 2024
| @@ -27,6 +27,11 @@ | |||
| [squint.internal.protocols :as protocols]) | |||
| #?(:cljs (:require-macros [squint.resource :refer [edn-resource]]))) | |||
|
|
|||
| (defn opts+cfg->paths [opts cfg] | |||
| (-> (into (:paths cfg []) (:paths opts [])) | |||
There was a problem hiding this comment.
This merges the paths, rather than overriding paths. Why not just merge the opts with cfg, then take the paths and or that with ["." "src"]?
|
@rafaeldelboni Shouldn't this just fix it? |
|
released 0.8.122 |
|
Thanks! Sure makes sense I didn't understand the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this one on the last PR (#566)
The compiler internal function not overriding
squint.ednconfigurations with command line options--paths.This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.