Fix export of class name with dashes, #526 (#528)

squint-cljs · May 7, 2024 · 6497300 · 6497300
1 parent 751ee69
commit 6497300
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## v.0.7.108
 
 - [#492](https://github.com/squint-cljs/squint/issues/492): defclass static methods and fields
+- [#526](https://github.com/squint-cljs/squint/issues/526): Fix export of class name with dashes
 
 ## v0.7.107
 

diff --git a/src/squint/compiler_common.cljc b/src/squint/compiler_common.cljc
@@ -1079,7 +1079,7 @@ break;}" body)
 
 (defmethod emit-special 'squint.defclass/defclass* [_ env form]
   (let [name (second form)]
-    (swap! *public-vars* conj name)
+    (swap! *public-vars* conj (munge* name))
     (defclass/emit-class env
       emit
       (fn [async body-fn]

diff --git a/test/squint/compiler_test.cljs b/test/squint/compiler_test.cljs
@@ -1704,8 +1704,8 @@
 (deftest defclass-test
   (async done
     #_(println (jss! (str (fs/readFileSync "test-resources/defclass_test.cljs"))))
-    (is (str/includes? (compiler/compile-string "(defclass Foo (constructor [this]))")
-                       "export { Foo }"))
+    (is (str/includes? (compiler/compile-string "(defclass Foo-bar (constructor [this]))")
+                       "export { Foo_bar }"))
     (is (str/includes? (:javascript (compiler/compile-string* "(defclass Foo (constructor [this]))" {:repl true
                                                                                                      :context :return}))
                        "return Foo"))