Fix re-usage of reductions return value

squint-cljs · Dec 7, 2023 · 5837bad · 5837bad
1 parent 713e850
commit 5837bad
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/squint/core.js b/src/squint/core.js
@@ -620,9 +620,13 @@ function _reductions3(f, init, coll) {
 export function reductions(f, arg1, arg2) {
   f = toFn(f);
   if (arg2 === undefined) {
-    return _reductions2(f, arg1);
+    return lazy(function* () {
+      yield* _reductions2(f, arg1);
+    });
   }
-  return _reductions3(f, arg1, arg2);
+  return lazy(function* () {
+    yield* _reductions3(f, arg1, arg2);
+  });
 }
 
 var tolr = false;

diff --git a/test/squint/compiler_test.cljs b/test/squint/compiler_test.cljs
@@ -1024,7 +1024,13 @@
     (is (= 100 (jsv! '(do (def a (atom []))
                           (defn spy [x] (swap! a conj x) x)
                           (vec (reductions + (map spy (range 100))))
-                          (count @a)))))))
+                          (count @a)))))
+    (is (eq (do
+              (let [ xs (reductions + (range 3))]
+                [(count xs) (count xs)]))
+            (jsv! '(do
+                     (let [ xs (reductions + (range 3))]
+                       [(count xs) (count xs)])))))))
 
 (deftest seq-test
   (is (= "abc" (jsv! '(seq "abc"))))