Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add supported nodejs version #13

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Conversation

PCOffline
Copy link
Contributor

No description provided.

@4kimov
Copy link
Member

4kimov commented Nov 19, 2023

Thanks for the suggestion. Instead of updating the README, could you add it to engines.node in package.json?

@PCOffline
Copy link
Contributor Author

PCOffline commented Nov 19, 2023

Why not both?

@4kimov
Copy link
Member

4kimov commented Nov 19, 2023

We generally don't support EOL platforms (unless there's demand for it), v18 is the oldest that still has security support, so there shouldn't be surprises there; package.json will make it obvious.

@PCOffline
Copy link
Contributor Author

@4kimov done, sry for the delay

@4kimov 4kimov merged commit 28a8b6b into sqids:main Nov 26, 2023
5 checks passed
@4kimov
Copy link
Member

4kimov commented Nov 26, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants