chore: early exit when encoding invalid numbers

Before this change, we checked the validity of every number during encoding. Now, we stop if we find an invalid one. In my testing, this was about twice as fast for invalid inputs. It had no performance impact for valid inputs, but should theoretically avoid an unnecessary array allocation.
sqids · Nov 26, 2023 · 77e9fe3 · 77e9fe3
1 parent ebca95e
commit 77e9fe3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/cjs/sqids.js b/cjs/sqids.js
diff --git a/dist/sqids.js b/dist/sqids.js
diff --git a/esm/sqids.js b/esm/sqids.js
diff --git a/src/sqids.ts b/src/sqids.ts
@@ -628,8 +628,10 @@ export default class Sqids {
       return ''
     }
 
-    const inRangeNumbers = numbers.filter((n) => n >= 0 && n <= this.maxValue())
-    if (inRangeNumbers.length !== numbers.length) {
+    const areAllNumbersInRange = numbers.every(
+      (n) => n >= 0 && n <= this.maxValue(),
+    )
+    if (!areAllNumbersInRange) {
       throw new Error(
         `Encoding supports numbers between 0 and ${this.maxValue()}`,
       )