use array as preferred for credential types #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanmtate
force-pushed
the
fix/preferred-presentation-types-array
branch
from
1fbc22c to
cddcfb3
Compare
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com> Co-Authored-By: Joey Silberman <joey.silberman@spruceid.com> Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
Ryanmtate
force-pushed
the
fix/preferred-presentation-types-array
branch
from
cddcfb3 to
bd607e6
Compare
|
Looking into the failing test. |
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
timothee-haudebourg
approved these changes
Dec 10, 2024
timothee-haudebourg
requested changes
Dec 10, 2024
Ryanmtate
commented
Dec 10, 2024
timothee-haudebourg
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
PREFER_ARRAYtotrueforRequiredTypetrait implementation forPresentationType.Received verifiable presentation submission schema validation errors complaining about
typeproperty being astringinstead of anarray.Tested
Tested using VC playground oid4vp in sprucekit-mobile.