Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add shouldApply to control sending apply #188

Merged
merged 2 commits into from
Feb 11, 2025
Merged

feat: add shouldApply to control sending apply #188

merged 2 commits into from
Feb 11, 2025

Conversation

nickybondarenko
Copy link
Contributor

The SDK will use shouldApply boolean coming from backend service when sending an apply event.

@nickybondarenko nickybondarenko force-pushed the use-shouldapply-from-resolver branch 2 times, most recently from ec46cee to 5e75ab9 Compare February 10, 2025 14:23
@nickybondarenko nickybondarenko force-pushed the use-shouldapply-from-resolver branch from 5e75ab9 to ba091fb Compare February 10, 2025 14:26
@nickybondarenko nickybondarenko marked this pull request as ready for review February 10, 2025 14:32
nicklasl
nicklasl approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@nicklasl nicklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I think we should merge this.

But we should think about refactoring the evaluate function. It's is somewhat of a mess and we have 4 different paths to call apply 👎

@nickybondarenko nickybondarenko merged commit a4b1e0a into main Feb 11, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklasl nicklasl nicklasl approved these changes

@fabriziodemaria fabriziodemaria Awaiting requested review from fabriziodemaria fabriziodemaria is a code owner

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickybondarenko @nicklasl