Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update peer deps to min and max version ranges #213

Merged
merged 6 commits into from
Jan 29, 2025
Merged

chore: update peer deps to min and max version ranges #213

merged 6 commits into from
Jan 29, 2025

Conversation

msvens
Copy link
Contributor

@msvens msvens commented Jan 28, 2025

Hi There, I just made a Pull Request!

✔️ Checklist

  • All tests are passing
  • Relevant documentation updated
  • linter/style run on changed files
  • Tests added for new functionality
  • Regression tests added for bug fixes
  • Tested in a corresponding example app

andreas-karlsson
andreas-karlsson reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@andreas-karlsson andreas-karlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change. The real fix is that we want to still allow 0.1.4, but just also include 0.2.x. We could put it as >=0.1.4 that wouldn't be breaking, and then we should only bump it when we actually need something new from the sdk.

@nicklasl nicklasl changed the title update peer deps chore: update peer deps Jan 28, 2025
@msvens
Copy link
Contributor Author

msvens commented Jan 28, 2025

Ok thanks. Will go ahead with that.

@msvens @nicklasl
chore!: update peer deps
e0b52cd 
update peer deps

update peer deps

chore!: use caret for 0.2.0
nicklasl
nicklasl reviewed Jan 29, 2025
View reviewed changes
@nicklasl nicklasl changed the title chore: update peer deps chore!: update peer deps to use sdk ^0.2.0 Jan 29, 2025
@nicklasl nicklasl changed the title chore!: update peer deps to use sdk ^0.2.0 chore: update peer deps to use sdk ^0.2.0 Jan 29, 2025
@nicklasl nicklasl changed the title chore: update peer deps to use sdk ^0.2.0 chore: update peer deps to min and max version ranges Jan 29, 2025
@andreas-karlsson andreas-karlsson merged commit b805491 into main Jan 29, 2025
2 checks passed
@andreas-karlsson andreas-karlsson deleted the update-peer-deps branch January 29, 2025 13:58
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklasl nicklasl nicklasl left review comments

@andreas-karlsson andreas-karlsson andreas-karlsson approved these changes

@Billlynch Billlynch Awaiting requested review from Billlynch Billlynch is a code owner

@fabriziodemaria fabriziodemaria Awaiting requested review from fabriziodemaria fabriziodemaria is a code owner

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msvens @andreas-karlsson @nicklasl