feat: add a custom baseURL for sidecar resolves #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickybondarenko
force-pushed
the
custom-url-sidecar
branch
3 times, most recently
from
6b90ede to
3a0f252
Compare
nickybondarenko
changed the title
nicklasl
reviewed
Sep 11, 2024
nicklasl
reviewed
Sep 11, 2024
nicklasl
reviewed
Sep 11, 2024
nicklasl
reviewed
Sep 11, 2024
nickybondarenko
force-pushed
the
custom-url-sidecar
branch
from
3a0f252 to
6426400
Compare
nickybondarenko
requested review from
Billlynch,
andreas-karlsson,
fabriziodemaria,
mfranberg and
vahidlazio
as code owners
nickybondarenko
changed the title
nickybondarenko
force-pushed
the
custom-url-sidecar
branch
from
881be24 to
3702fb0
Compare
andreas-karlsson
approved these changes
Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we're adding a possibility to use a custom url in order to sidecar resolves.