Merge pull request #62 from tomaslin/optional-pounding

tomaslin · tomaslin · commit 0d79d03288fc · 2016-01-25T20:56:45.000-08:00
make the pound (#) in a slack channel name optional
diff --git a/echo-notifications/src/main/groovy/com/netflix/spinnaker/echo/slack/SlackNotificationService.groovy b/echo-notifications/src/main/groovy/com/netflix/spinnaker/echo/slack/SlackNotificationService.groovy
@@ -48,8 +48,8 @@ class SlackNotificationService implements NotificationService {
     def body = notificationTemplateEngine.build(notification, NotificationTemplateEngine.Type.BODY)
     notification.to.each {
       slack.sendMessage(token, new SlackMessage(
-          text: body,
-          channel: it
+        text: body,
+        channel: it.startsWith('#') ? it : "#${it}".toString()
       ))
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ class SlackNotificationService implements NotificationService {`
`48`	`48`	`def body = notificationTemplateEngine.build(notification, NotificationTemplateEngine.Type.BODY)`
`49`	`49`	`notification.to.each {`
`50`	`50`	`slack.sendMessage(token, new SlackMessage(`
`51`		`- text: body,`
`52`		`- channel: it`
	`51`	`+ text: body,`
	`52`	`+ channel: it.startsWith('#') ? it : "#${it}".toString()`
`53`	`53`	`))`
`54`	`54`	`}`
`55`	`55`	`}`