Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the overview figure #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

valosekj
Copy link
Member

Changes:

  • udpate segmentation box
  • remove motion correction box
  • merge template and atlas boxes into a single box
  • add a new lesion analysis box
  • add a new compression analysis box

 - udpate segmentation box
 - remove motion correction box
 - merge template and atlas boxes into a single box
 - add a new lesion analysis box
 - add a new compression analysis box
Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are beautiful! There's a lot I love:

  • Removing the tiny, unreadable text in the old Segmentation bubble.
  • Adding very legible, colorful graphics in the Segmentation bubble.
  • Increasing the size of the SCT logo and bubbles to make it more legible on smaller screens.
  • The "zoomed in" lesion analysis figure does a great job illustrating the process.

My only critique is that there are still a few instances of tiny, unreadable text?

  • In the "Template and atlas" bubble, the tract-based analysis shows 4 images + metric table. I wonder if it would be better to remove the metric table, and zoom in a little closer on the tracts?
  • In the "Compression analysis" bubble, we see the 6 different shape morphometrics, but they are quite small (due to the graphs taking up a lot of space). I wonder if it would be better to, say, have only 1 graph (even if this is factually incorrect), and then blow up the morphometrics cord cross-section images to better display each metric?

These are nitpicks though, and overall I'm very happy with the changes. ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants