Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for AAC audio encoding #295

Open
JonnyTran opened this issue Jan 30, 2025 · 0 comments · May be fixed by #299
Open

Adding support for AAC audio encoding #295

JonnyTran opened this issue Jan 30, 2025 · 0 comments · May be fixed by #299

Comments

@JonnyTran
Copy link

JonnyTran commented Jan 30, 2025 •
edited
Loading

I found that in src/speaches/routers/speech.py, "aac" was not supported. Some iOS app that can use an OpenAI TTS backend typically requires aac format. Since ffmpeg is installed, would it be as simple as adding it to the SUPPORTED_RESPONSE_FORMATS and letting convert_audio_format perform the conversion?

SUPPORTED_RESPONSE_FORMATS = ("mp3", "flac", "wav", "pcm")
UNSUPORTED_RESPONSE_FORMATS = ("opus",  "aac")
@JonnyTran JonnyTran linked a pull request Jan 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for AAC audio encoding JonnyTran/speaches
1 participant
@JonnyTran