Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions #151

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix Github Actions #151

merged 2 commits into from
Jan 17, 2025

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jan 17, 2025

Github Actions Workflow is invalid. This PR fixes the syntax, so that tests are running again.
See: https://github.com/spatie/nova-backup-tool/actions/runs/12827959091

exclude should be formatted differently:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrixexclude

spatie/laravel-backup required PHP 8.2. Which did not see, because the tests were not running. Therefor reverting PHP 8.1 support.

Problems: Missing nova license for me, therefore composer dependencies are not getting installed. Not sure if tests are passing, as I have no Nova license.

@Jubeki Jubeki marked this pull request as draft January 17, 2025 11:18
@Jubeki Jubeki marked this pull request as ready for review January 17, 2025 11:20
@freekmurze freekmurze merged commit 582ea08 into spatie:main Jan 17, 2025
0 of 5 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants