Skip to content

Commit

Permalink
fix issue #32
Browse files Browse the repository at this point in the history
  • Loading branch information
freekmurze committed Apr 27, 2015
1 parent 10e8bc1 commit 686353a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Changelog

All Notable changes to `laravel-backup` will be documented in this file

### 2.3.2
- Fixed a bug that caused a failure when backing up a large db

### 2.3.1
- Fixed a bug where the backups would not be stored in the right directory

Expand Down
2 changes: 1 addition & 1 deletion src/BackupHandlers/Database/DatabaseBackupHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function getDumpedDatabase()

$success = $this->getDatabase()->dump($tempFile);

if (! $success || file_get_contents($tempFile) == '') {
if (! $success || filesize($tempFile) == 0) {
throw new Exception('Could not create backup of db');
}

Expand Down

0 comments on commit 686353a

Please sign in to comment.