Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digikey localization #65

Closed
Snevzor opened this issue Oct 20, 2021 · 9 comments · Fixed by #270
Closed

Digikey localization #65

Snevzor opened this issue Oct 20, 2021 · 9 comments · Fixed by #270
Labels
enhancement New feature or request

Comments

@Snevzor
Copy link

Snevzor commented Oct 20, 2021

When adding a part using the Digikey API the link to the part is "digikey.com....." while I would like it to be "digikey.be...".

Is that something that could be tweaked in Ki-nTree or is this specific to Digikey.

@eeintech
Copy link
Contributor

Good point @Snevzor

The Digi-Key API supports language/country selection in the GET parameters, and the python API used in this project enables it through the x_digikey_locale_language kwarg parameter passed to the PartSearchAPI.product_details method.
I will need to add and test it out, then probably this will have to become a Digi-Key setting so that all request use the pre-selected country (default: US).

@eeintech eeintech added the enhancement New feature or request label Oct 21, 2021
@eeintech
Copy link
Contributor

For reference: https://developer.digikey.com/products/product-information/partsearch/productdetails

@Snevzor
Copy link
Author

Snevzor commented Oct 21, 2021

Great! Maybe I'll find some time next week to look at it myself. 🙏

@eeintech
Copy link
Contributor

That'd be awesome! I don't have a lot of time right now... 😕

@eeintech
Copy link
Contributor

Hi @Snevzor

Are you still interested into implementing this?

@Snevzor
Copy link
Author

Snevzor commented Apr 15, 2022

Hi @eeintech, sorry for the late response.
I briefly looked into it and it seemd feasible but then I realised that when logged in to Digikey the .com links are redirected to the local one automatically and for me that's fine for now.

@eeintech
Copy link
Contributor

Cool, yes I noticed the redirects too. I'll close for now and we can re-open as needed.

@LukeARESYS
Copy link

Sorry for resuscitating an old issue, but we would like to be able to change the Digikey search locale to be able to get prices in the correct currency and correct stock availability while keeping the english language.

It would be awesome to be able to set the x_digikey_locale_site, x_digikey_locale_language and x_digikey_locale_currency, as stated in this digikey_api issue

@eeintech eeintech reopened this Jul 19, 2024
@eeintech
Copy link
Contributor

@LukeARESYS I reopened the issue as I wish to migrate to the new Digi-Key API too: peeter123/digikey-api#51

@eeintech eeintech mentioned this issue Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants