Skip to content

NASA Challenge_[@elementrobotics]_[LunarSim] (closes space-ros/demos#50) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

mazm0002
Copy link

@mazm0002 mazm0002 commented Sep 9, 2024

Depends on space-ros/demos#51

This PR adds instructions to run the spaceROS Lunar Sim demo as well as extensive documentation on how users can integrate their own Digital Elevation Models (DEMs), Ephemeris data and textures.

@ivanperez-keera
Copy link
Contributor

Hi @mazm0002 . I'd like to prepare this issue for merging together with the demo.

I tried to make the following changes to make the PR comply with our process.

Can you please:

  • Squash all commits.
  • Modify the commit message of the only commit (after squash) to the following:
Added page in docs for lunar sim instructions (#44).
    
The demonstrations now include a lunar simulation.
    
This commit adds a documentation page to the website describing how the
simulation can be built and run.

The demonstrations now include a lunar simulation.

This commit adds a documentation page to the website describing how the
simulation can be built and run.
@mazm0002
Copy link
Author

mazm0002 commented Apr 3, 2025

Hi @ivanperez-keera, thanks for helping in getting this merged! I've squashed the commits and changed the message to the suggested one. Let me know if anything else needs to be fixed here or with the demo.

@ivanperez-keera
Copy link
Contributor

Thank you @mazm0002 for acting so quickly on this. I'll review the associated PR in the demos repo and post any other requests for changes there.

It makes sense to merge things first in the demos repo and then here, just so that we don't have documentation that points to a demo that is not merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants