Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use iterators for FlatMap equality checks #26

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 22, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 782de09 Previous: 214d23b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.209336993541995 ns/iter 2.2050867231326547 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.194394214416887 ns/iter 2.2100882315668424 ns/iter 0.99
Regex_Period_Asterisk 2.209614306848024 ns/iter 2.1978781538054655 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 2.212415799181412 ns/iter 2.194200727383446 ns/iter 1.01
Regex_Period_Plus 2.4948887103917996 ns/iter 2.5552775977381 ns/iter 0.98
Regex_Period 2.4892612309284026 ns/iter 2.492076400102254 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.4934853635895093 ns/iter 2.2425677651340394 ns/iter 1.11
Regex_Caret_Group_Period_Plus_Group_Dollar 2.494381364797789 ns/iter 2.357148097311435 ns/iter 1.06
Regex_Caret_Period_Asterisk_Dollar 3.4194244349032434 ns/iter 2.486882812300636 ns/iter 1.37
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4195349062533147 ns/iter 2.4877530515428172 ns/iter 1.37
Regex_Caret_X_Hyphen 13.058754970206897 ns/iter 13.053329939595303 ns/iter 1.00
Regex_Period_Md_Dollar 73.09651218416596 ns/iter 73.97677875287161 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 6.164464547827068 ns/iter 7.160430719688381 ns/iter 0.86
Regex_Caret_Period_Range_Dollar 2.797538056725681 ns/iter 4.039346444819488 ns/iter 0.69
Regex_Nested_Backtrack 458.68291082784447 ns/iter 458.01741358677566 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 782de09 Previous: 214d23b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.2354570003821475 ns/iter 1.6401514303339735 ns/iter 1.36
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.196484565170083 ns/iter 1.5944826791695377 ns/iter 1.38
Regex_Period_Asterisk 2.1850442526461307 ns/iter 1.5968626160683688 ns/iter 1.37
Regex_Group_Period_Asterisk_Group 2.2462344419384146 ns/iter 1.62399569454731 ns/iter 1.38
Regex_Period_Plus 2.619273579397862 ns/iter 1.9352386635555838 ns/iter 1.35
Regex_Period 2.4732956668862918 ns/iter 1.9471920043530595 ns/iter 1.27
Regex_Caret_Period_Plus_Dollar 2.7431724432892994 ns/iter 1.9271781290128638 ns/iter 1.42
Regex_Caret_Group_Period_Plus_Group_Dollar 2.5439023232585947 ns/iter 1.9170267888698804 ns/iter 1.33
Regex_Caret_Period_Asterisk_Dollar 2.3304566042269754 ns/iter 1.5969896400338144 ns/iter 1.46
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.2499424612016488 ns/iter 1.600677523665264 ns/iter 1.41
Regex_Caret_X_Hyphen 8.766555878987372 ns/iter 6.749282019105777 ns/iter 1.30
Regex_Period_Md_Dollar 89.17716724092047 ns/iter 70.73669768358648 ns/iter 1.26
Regex_Caret_Slash_Period_Asterisk 6.429787904423716 ns/iter 5.084395979246659 ns/iter 1.26
Regex_Caret_Period_Range_Dollar 3.1170768283864585 ns/iter 2.228777172474936 ns/iter 1.40
Regex_Nested_Backtrack 959.4291774910527 ns/iter 751.2890471935256 ns/iter 1.28

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 782de09 Previous: 214d23b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.8032892608314812 ns/iter 3.7418133562061575 ns/iter 0.75
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.797401731758676 ns/iter 3.7278165694701837 ns/iter 0.75
Regex_Period_Asterisk 2.7991166582535194 ns/iter 3.7297565229277674 ns/iter 0.75
Regex_Group_Period_Asterisk_Group 2.7982653623172724 ns/iter 3.7288010954764115 ns/iter 0.75
Regex_Period_Plus 2.8059233115570392 ns/iter 3.7357140064808174 ns/iter 0.75
Regex_Period 2.496976182248488 ns/iter 3.7282925348027427 ns/iter 0.67
Regex_Caret_Period_Plus_Dollar 2.8084884327397757 ns/iter 3.7309961505397142 ns/iter 0.75
Regex_Caret_Group_Period_Plus_Group_Dollar 2.8026117721655623 ns/iter 3.7296894842484156 ns/iter 0.75
Regex_Caret_Period_Asterisk_Dollar 3.1138574813859035 ns/iter 3.7324915127605673 ns/iter 0.83
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.7982406902747368 ns/iter 3.7279085104007583 ns/iter 0.75
Regex_Caret_X_Hyphen 12.433583101440634 ns/iter 12.431306255993519 ns/iter 1.00
Regex_Period_Md_Dollar 89.06767075861046 ns/iter 89.63559153647003 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 6.529070539486486 ns/iter 6.522908908999184 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 4.351068109268302 ns/iter 4.357682754572321 ns/iter 1.00
Regex_Nested_Backtrack 838.3466188527232 ns/iter 836.166719026071 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 782de09 Previous: 214d23b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 7.106382812499692 ns/iter 6.9072165178571 ns/iter 1.03
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 6.874870535714196 ns/iter 6.883229910714661 ns/iter 1.00
Regex_Period_Asterisk 7.298786830358038 ns/iter 7.090626116072078 ns/iter 1.03
Regex_Group_Period_Asterisk_Group 6.858553571427808 ns/iter 7.217571428571442 ns/iter 0.95
Regex_Period_Plus 7.148637276785306 ns/iter 7.219037946428435 ns/iter 0.99
Regex_Period 7.561809341241507 ns/iter 7.220366485623528 ns/iter 1.05
Regex_Caret_Period_Plus_Dollar 7.22003568205304 ns/iter 7.2370301339283065 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 7.209024553571958 ns/iter 7.178620950095945 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 7.02996763392884 ns/iter 6.850829433701918 ns/iter 1.03
Regex_Caret_Group_Period_Asterisk_Group_Dollar 7.114104910715164 ns/iter 6.961850000000221 ns/iter 1.02
Regex_Caret_X_Hyphen 11.960128571428998 ns/iter 11.88890714285711 ns/iter 1.01
Regex_Period_Md_Dollar 138.95151611823582 ns/iter 137.56646037651123 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 10.730821874998853 ns/iter 10.521857812499036 ns/iter 1.02
Regex_Caret_Period_Range_Dollar 7.646937500000053 ns/iter 7.558535714286155 ns/iter 1.01
Regex_Nested_Backtrack 590.6185999999707 ns/iter 598.9221428571057 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 2ce51f8 into main Jan 22, 2025
13 checks passed
@jviotti jviotti deleted the flat-map-equality-iterators branch January 22, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant