Remove wrong TODO comment

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[github-actions]

Benchmark (linux/llvm)

Benchmark suite	Current: b2e5cc3	Previous: 40811fd	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	2.1865903137652776 ns/iter	2.2524355685766535 ns/iter	0.97
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	2.1804892262696987 ns/iter	2.2491437489944506 ns/iter	0.97
Regex_Period_Asterisk	2.1799470702642476 ns/iter	2.1889586990085563 ns/iter	1.00
Regex_Group_Period_Asterisk_Group	2.191314250715338 ns/iter	2.244542826644611 ns/iter	0.98
Regex_Period_Plus	2.48563905597818 ns/iter	2.4856376761334333 ns/iter	1.00
Regex_Period	2.2038751893486834 ns/iter	2.4867062303003595 ns/iter	0.89
Regex_Caret_Period_Plus_Dollar	2.221323401383747 ns/iter	2.48594365824639 ns/iter	0.89
Regex_Caret_Group_Period_Plus_Group_Dollar	2.2146068420739695 ns/iter	2.4865190365064342 ns/iter	0.89
Regex_Caret_Period_Asterisk_Dollar	2.513575332652066 ns/iter	3.417693952077679 ns/iter	0.74
Regex_Caret_Group_Period_Asterisk_Group_Dollar	2.488114307924612 ns/iter	3.4517591658275566 ns/iter	0.72
Regex_Caret_X_Hyphen	12.674636719724852 ns/iter	13.0483909685878 ns/iter	0.97
Regex_Period_Md_Dollar	74.86076985980876 ns/iter	75.55590650227391 ns/iter	0.99
Regex_Caret_Slash_Period_Asterisk	7.149229406560218 ns/iter	7.148949041307031 ns/iter	1.00
Regex_Caret_Period_Range_Dollar	4.040732072501531 ns/iter	4.043769373026741 ns/iter	1.00
Regex_Nested_Backtrack	454.966770231465 ns/iter	482.79414739284783 ns/iter	0.94
JSON_Array_Of_Objects_Unique	405.65386918468033 ns/iter	406.4844273414305 ns/iter	1.00
JSON_Parse_1	30464.768770474846 ns/iter	29968.78952126586 ns/iter	1.02
JSON_Fast_Hash_Helm_Chart_Lock	59.65716519144598 ns/iter	59.71156755456447 ns/iter	1.00
JSON_Equality_Helm_Chart_Lock	158.17701467955754 ns/iter	145.41805472995696 ns/iter	1.09
JSON_String_Equal/10	6.845630509025159 ns/iter	6.224737426969583 ns/iter	1.10
JSON_String_Equal/100	7.516928521265191 ns/iter	6.852976463092852 ns/iter	1.10
JSON_String_Equal_Small_By_Perfect_Hash/10	0.959849069783121 ns/iter	0.9349877472332301 ns/iter	1.03
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	10.25695418072913 ns/iter	10.258557969520417 ns/iter	1.00
JSON_String_Fast_Hash/10	2.1760625628595913 ns/iter	2.1777875864590013 ns/iter	1.00
JSON_String_Fast_Hash/100	2.178261426177796 ns/iter	2.17919765585758 ns/iter	1.00
JSON_String_Key_Hash/10	1.8685715247441563 ns/iter	1.867185391903357 ns/iter	1.00
JSON_String_Key_Hash/100	2.178302668123236 ns/iter	2.184324580247358 ns/iter	1.00
JSON_Object_Defines_Miss_Same_Length	3.7407286877505532 ns/iter	3.7370593565952626 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Small	3.735504363410607 ns/iter	3.7337599443705267 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Large	3.735423551944035 ns/iter	3.7351545886847863 ns/iter	1.00
Pointer_Object_Traverse	45.735026755757026 ns/iter	44.3301400045434 ns/iter	1.03
Pointer_Object_Try_Traverse	52.41008200506181 ns/iter	52.33808635302092 ns/iter	1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer	383.2436850801193 ns/iter	287.07895163575995 ns/iter	1.33
Schema_Frame_OMC_Instances	225186129.6666675 ns/iter	218223493.66667974 ns/iter	1.03
Schema_Frame_OMC_References	146484850.1999995 ns/iter	140522308.9999936 ns/iter	1.04
Schema_Bundle_Meta_2020_12	6847386.470583923 ns/iter	6750540.127454234 ns/iter	1.01

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (macos/llvm)

Benchmark suite	Current: b2e5cc3	Previous: 40811fd	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	1.8030437283190162 ns/iter	1.6524401661478387 ns/iter	1.09
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	1.8845408732683642 ns/iter	1.6526439737075045 ns/iter	1.14
Regex_Period_Asterisk	1.7390651759355298 ns/iter	1.6875788608461224 ns/iter	1.03
Regex_Group_Period_Asterisk_Group	1.6866963917383269 ns/iter	1.7382650168282852 ns/iter	0.97
Regex_Period_Plus	2.0563038293365463 ns/iter	2.0400109886888877 ns/iter	1.01
Regex_Period	2.026870495699208 ns/iter	2.2479022616101227 ns/iter	0.90
Regex_Caret_Period_Plus_Dollar	2.0516577992715574 ns/iter	2.0130977354912996 ns/iter	1.02
Regex_Caret_Group_Period_Plus_Group_Dollar	1.996224571687407 ns/iter	2.058997148395842 ns/iter	0.97
Regex_Caret_Period_Asterisk_Dollar	1.6947071686540467 ns/iter	1.748080084526344 ns/iter	0.97
Regex_Caret_Group_Period_Asterisk_Group_Dollar	1.718237628833626 ns/iter	1.6769760178135347 ns/iter	1.02
Regex_Caret_X_Hyphen	6.780716622895131 ns/iter	6.764604017142676 ns/iter	1.00
Regex_Period_Md_Dollar	71.52705451453295 ns/iter	72.74263021671459 ns/iter	0.98
Regex_Caret_Slash_Period_Asterisk	6.19485837348109 ns/iter	6.374438369228721 ns/iter	0.97
Regex_Caret_Period_Range_Dollar	2.1903017353823833 ns/iter	2.1950693884181014 ns/iter	1.00
Regex_Nested_Backtrack	812.7016925206354 ns/iter	749.3725246821905 ns/iter	1.08
JSON_Array_Of_Objects_Unique	431.07402159100684 ns/iter	362.4918774794174 ns/iter	1.19
JSON_Parse_1	25422.127958612095 ns/iter	23312.21994934949 ns/iter	1.09
JSON_Fast_Hash_Helm_Chart_Lock	52.143574810437386 ns/iter	52.83557657889921 ns/iter	0.99
JSON_Equality_Helm_Chart_Lock	128.17373199179 ns/iter	128.59850162738897 ns/iter	1.00
JSON_String_Equal/10	8.179695404479467 ns/iter	8.183139528123645 ns/iter	1.00
JSON_String_Equal/100	6.398377533601533 ns/iter	6.450812636329488 ns/iter	0.99
JSON_String_Equal_Small_By_Perfect_Hash/10	0.34080337810096795 ns/iter	0.3351808219839822 ns/iter	1.02
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	3.1160085015031647 ns/iter	3.0250134374878375 ns/iter	1.03
JSON_String_Fast_Hash/10	1.6810744918912324 ns/iter	1.6261564202685355 ns/iter	1.03
JSON_String_Fast_Hash/100	2.017346916997537 ns/iter	1.9584042499159988 ns/iter	1.03
JSON_String_Key_Hash/10	1.4189343362850488 ns/iter	1.3010418871965896 ns/iter	1.09
JSON_String_Key_Hash/100	1.4284893412219843 ns/iter	1.3597576240276832 ns/iter	1.05
JSON_Object_Defines_Miss_Same_Length	2.3935109000444807 ns/iter	2.3533549146242527 ns/iter	1.02
JSON_Object_Defines_Miss_Too_Small	2.3301370366051186 ns/iter	2.2811498541155513 ns/iter	1.02
JSON_Object_Defines_Miss_Too_Large	2.3550368607352863 ns/iter	2.276379645695983 ns/iter	1.03
Pointer_Object_Traverse	16.413637074589 ns/iter	15.936785138278632 ns/iter	1.03
Pointer_Object_Try_Traverse	23.45605773886167 ns/iter	23.26351254950056 ns/iter	1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer	178.66887966869987 ns/iter	184.65359538585577 ns/iter	0.97
Schema_Frame_OMC_Instances	176480187.5000046 ns/iter	171227656.2499824 ns/iter	1.03
Schema_Frame_OMC_References	102778077.42857346 ns/iter	107592059.57143487 ns/iter	0.96
Schema_Bundle_Meta_2020_12	5068255.804197853 ns/iter	4628145.026317336 ns/iter	1.10

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (windows/msvc)

Benchmark suite	Current: b2e5cc3	Previous: 40811fd	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	6.753689732142172 ns/iter	6.812839285714745 ns/iter	0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	6.8147053571416505 ns/iter	6.5706283482138055 ns/iter	1.04
Regex_Period_Asterisk	6.51737723214347 ns/iter	6.8130357142872 ns/iter	0.96
Regex_Group_Period_Asterisk_Group	6.5538816964304045 ns/iter	6.877338169642501 ns/iter	0.95
Regex_Period_Plus	6.900488839287939 ns/iter	7.04326562499905 ns/iter	0.98
Regex_Period	6.944947544642589 ns/iter	6.9213053571429235 ns/iter	1.00
Regex_Caret_Period_Plus_Dollar	7.183922991071004 ns/iter	7.009260236565747 ns/iter	1.02
Regex_Caret_Group_Period_Plus_Group_Dollar	6.889210683532029 ns/iter	6.912768973213547 ns/iter	1.00
Regex_Caret_Period_Asterisk_Dollar	6.8363794642856135 ns/iter	6.850178571430173 ns/iter	1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar	6.553066964285798 ns/iter	6.537819196427312 ns/iter	1.00
Regex_Caret_X_Hyphen	11.882533928570636 ns/iter	14.407860873183111 ns/iter	0.82
Regex_Period_Md_Dollar	155.53408482139122 ns/iter	155.17669642858118 ns/iter	1.00
Regex_Caret_Slash_Period_Asterisk	10.13134013334229 ns/iter	10.429505310583512 ns/iter	0.97
Regex_Caret_Period_Range_Dollar	7.167889508927772 ns/iter	7.3454162946414865 ns/iter	0.98
Regex_Nested_Backtrack	589.5887499998968 ns/iter	595.2589000000899 ns/iter	0.99
JSON_Array_Of_Objects_Unique	416.65415997084085 ns/iter	418.58030720631984 ns/iter	1.00
JSON_Parse_1	78940.37946429527 ns/iter	79658.93973214123 ns/iter	0.99
JSON_Fast_Hash_Helm_Chart_Lock	59.28536607141512 ns/iter	58.17576785714453 ns/iter	1.02
JSON_Equality_Helm_Chart_Lock	189.01031176409347 ns/iter	190.56240094303493 ns/iter	0.99
JSON_String_Equal/10	9.307711565591452 ns/iter	9.310008440579207 ns/iter	1.00
JSON_String_Equal/100	9.92384531249968 ns/iter	9.956038348411036 ns/iter	1.00
JSON_String_Equal_Small_By_Perfect_Hash/10	2.1665962500001967 ns/iter	2.1701293750005846 ns/iter	1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	14.570909277429267 ns/iter	14.688616071428635 ns/iter	0.99
JSON_String_Fast_Hash/10	3.1010739690609155 ns/iter	3.1048254464280944 ns/iter	1.00
JSON_String_Fast_Hash/100	3.094663392856895 ns/iter	3.097540178571429 ns/iter	1.00
JSON_String_Key_Hash/10	7.516098180732962 ns/iter	7.501848214285392 ns/iter	1.00
JSON_String_Key_Hash/100	3.7213157076408185 ns/iter	3.7177430290760807 ns/iter	1.00
JSON_Object_Defines_Miss_Same_Length	4.025186525045889 ns/iter	4.032873355415496 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Small	3.4074567349872242 ns/iter	3.4098531635539056 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Large	3.7456398147394263 ns/iter	3.717913386217351 ns/iter	1.01
Pointer_Object_Traverse	52.347866071430964 ns/iter	52.51914999998917 ns/iter	1.00
Pointer_Object_Try_Traverse	64.68591964284494 ns/iter	65.50177455356528 ns/iter	0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer	189.85190447084824 ns/iter	166.73663616536487 ns/iter	1.14
Schema_Frame_OMC_Instances	480481499.99999624 ns/iter	494104999.99999046 ns/iter	0.97
Schema_Frame_OMC_References	353037550.0000673 ns/iter	356275350.0000326 ns/iter	0.99
Schema_Bundle_Meta_2020_12	16263356.097585818 ns/iter	16382165.853661807 ns/iter	0.99

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (macos/gcc)

Benchmark suite	Current: b2e5cc3	Previous: 40811fd	Ratio
Regex_Lower_S_Or_Upper_S_Asterisk	1.8805054207449843 ns/iter	2.0576820454992486 ns/iter	0.91
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	1.8795382955300843 ns/iter	2.2254602000007275 ns/iter	0.84
Regex_Period_Asterisk	1.887054664734423 ns/iter	2.1768491414999196 ns/iter	0.87
Regex_Group_Period_Asterisk_Group	1.8813622383420148 ns/iter	2.2365049669578285 ns/iter	0.84
Regex_Period_Plus	1.5893456783233895 ns/iter	1.7169817525567015 ns/iter	0.93
Regex_Period	1.5762336445578637 ns/iter	1.7018017147285778 ns/iter	0.93
Regex_Caret_Period_Plus_Dollar	1.567685833434222 ns/iter	1.743193053827771 ns/iter	0.90
Regex_Caret_Group_Period_Plus_Group_Dollar	1.5946100563397039 ns/iter	1.7038603198815148 ns/iter	0.94
Regex_Caret_Period_Asterisk_Dollar	1.885075042314758 ns/iter	2.058055040201358 ns/iter	0.92
Regex_Caret_Group_Period_Asterisk_Group_Dollar	1.8805007800636295 ns/iter	2.0808705797590084 ns/iter	0.90
Regex_Caret_X_Hyphen	6.268565937381522 ns/iter	6.738110770254047 ns/iter	0.93
Regex_Period_Md_Dollar	67.50147717532887 ns/iter	76.02641254320713 ns/iter	0.89
Regex_Caret_Slash_Period_Asterisk	4.389333086503956 ns/iter	4.737173689091871 ns/iter	0.93
Regex_Caret_Period_Range_Dollar	1.8984631566064525 ns/iter	2.078316218855978 ns/iter	0.91
Regex_Nested_Backtrack	856.1895892150693 ns/iter	1078.8143754975456 ns/iter	0.79
JSON_Array_Of_Objects_Unique	200.23659682503592 ns/iter	218.36665993474094 ns/iter	0.92
JSON_Parse_1	22878.92144602439 ns/iter	25377.40038431049 ns/iter	0.90
JSON_Fast_Hash_Helm_Chart_Lock	23.566446383801424 ns/iter	25.83165128775895 ns/iter	0.91
JSON_Equality_Helm_Chart_Lock	116.1536893449581 ns/iter	127.78271412749208 ns/iter	0.91
JSON_String_Equal/10	5.369340685469889 ns/iter	5.827702596044208 ns/iter	0.92
JSON_String_Equal/100	5.052860987295979 ns/iter	5.843277427506388 ns/iter	0.86
JSON_String_Equal_Small_By_Perfect_Hash/10	0.7446389856279374 ns/iter	0.9358040401103531 ns/iter	0.80
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	3.8155677005066173 ns/iter	4.6790257052458335 ns/iter	0.82
JSON_String_Fast_Hash/10	1.8921098790944668 ns/iter	2.1439520743040936 ns/iter	0.88
JSON_String_Fast_Hash/100	1.8911159916100577 ns/iter	2.1419226253944372 ns/iter	0.88
JSON_String_Key_Hash/10	1.6103071312175745 ns/iter	1.7943521687885897 ns/iter	0.90
JSON_String_Key_Hash/100	1.9193351173625524 ns/iter	2.732340515582173 ns/iter	0.70
JSON_Object_Defines_Miss_Same_Length	1.72364503227182 ns/iter	1.9486051163527536 ns/iter	0.88
JSON_Object_Defines_Miss_Too_Small	1.8802518000293336 ns/iter	2.1865299705004904 ns/iter	0.86
JSON_Object_Defines_Miss_Too_Large	1.7241825702677016 ns/iter	1.8785193411613124 ns/iter	0.92
Pointer_Object_Traverse	52.29963254229241 ns/iter	56.47090488100189 ns/iter	0.93
Pointer_Object_Try_Traverse	36.02671694133139 ns/iter	39.628487114225855 ns/iter	0.91
Pointer_Push_Back_Pointer_To_Weak_Pointer	156.70729587888405 ns/iter	172.38828412292233 ns/iter	0.91
Schema_Frame_OMC_Instances	162806987.76245117 ns/iter	197542985.28035483 ns/iter	0.82
Schema_Frame_OMC_References	99649429.32128906 ns/iter	125469398.49853516 ns/iter	0.79
Schema_Bundle_Meta_2020_12	4640484.4877735665 ns/iter	5439381.266749183 ns/iter	0.85

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (linux/gcc)

Benchmark suite	Current: b2e5cc3	Previous: 40811fd	Ratio
Schema_Frame_OMC_Instances	226836453.66669226 ns/iter	214415124.3332999 ns/iter	1.06
Schema_Frame_OMC_References	144250400.40000567 ns/iter	140281902.20001307 ns/iter	1.03
Schema_Bundle_Meta_2020_12	6926700.564366514 ns/iter	6930590.584162099 ns/iter	1.00
Pointer_Object_Traverse	48.65140039064978 ns/iter	48.61445131822454 ns/iter	1.00
Pointer_Object_Try_Traverse	22.992201997487754 ns/iter	22.99039464663388 ns/iter	1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer	170.21971659687972 ns/iter	169.80396478599866 ns/iter	1.00
JSON_Array_Of_Objects_Unique	410.09916814682754 ns/iter	387.5620985974738 ns/iter	1.06
JSON_Parse_1	33370.758017770415 ns/iter	32986.45280347359 ns/iter	1.01
JSON_Fast_Hash_Helm_Chart_Lock	62.25409561090225 ns/iter	69.67940330808783 ns/iter	0.89
JSON_Equality_Helm_Chart_Lock	155.6830591903574 ns/iter	156.92294484975042 ns/iter	0.99
JSON_String_Equal/10	5.949879339358303 ns/iter	5.955502957270086 ns/iter	1.00
JSON_String_Equal/100	6.57411902927236 ns/iter	6.526330549997271 ns/iter	1.01
JSON_String_Equal_Small_By_Perfect_Hash/10	0.6272823531338224 ns/iter	0.6237830797357554 ns/iter	1.01
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10	11.671646176268824 ns/iter	11.665442655188171 ns/iter	1.00
JSON_String_Fast_Hash/10	0.9340181503222209 ns/iter	0.9344906078998881 ns/iter	1.00
JSON_String_Fast_Hash/100	0.9326670847207066 ns/iter	0.9354487892302512 ns/iter	1.00
JSON_String_Key_Hash/10	1.2446875658162961 ns/iter	1.2478703709165635 ns/iter	1.00
JSON_String_Key_Hash/100	0.9338185935371178 ns/iter	0.9453973792678927 ns/iter	0.99
JSON_Object_Defines_Miss_Same_Length	2.4877422752145537 ns/iter	2.489976355793389 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Small	2.4916764244585434 ns/iter	2.4887971431291085 ns/iter	1.00
JSON_Object_Defines_Miss_Too_Large	2.7976894728663053 ns/iter	2.802041748703646 ns/iter	1.00
Regex_Lower_S_Or_Upper_S_Asterisk	3.108191193425294 ns/iter	3.1109758717928733 ns/iter	1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar	2.797515386113552 ns/iter	2.797318703643183 ns/iter	1.00
Regex_Period_Asterisk	2.7973630926635744 ns/iter	2.8009774477797316 ns/iter	1.00
Regex_Group_Period_Asterisk_Group	2.7973860370139847 ns/iter	2.798233572515333 ns/iter	1.00
Regex_Period_Plus	3.1076689638472033 ns/iter	2.798292605446648 ns/iter	1.11
Regex_Period	3.107621079410439 ns/iter	2.797186734749314 ns/iter	1.11
Regex_Caret_Period_Plus_Dollar	3.1400504737751493 ns/iter	2.796581880393302 ns/iter	1.12
Regex_Caret_Group_Period_Plus_Group_Dollar	3.1076638313940657 ns/iter	2.79678057330418 ns/iter	1.11
Regex_Caret_Period_Asterisk_Dollar	4.04069176922635 ns/iter	2.795469700037361 ns/iter	1.45
Regex_Caret_Group_Period_Asterisk_Group_Dollar	4.041325121702434 ns/iter	2.796464349652676 ns/iter	1.45
Regex_Caret_X_Hyphen	13.677701670344144 ns/iter	13.148266567942578 ns/iter	1.04
Regex_Period_Md_Dollar	89.58181951144134 ns/iter	89.5108589415557 ns/iter	1.00
Regex_Caret_Slash_Period_Asterisk	9.01948050099391 ns/iter	7.771760980039079 ns/iter	1.16
Regex_Caret_Period_Range_Dollar	4.0548864671489735 ns/iter	3.4210828215332443 ns/iter	1.19
Regex_Nested_Backtrack	825.1077481437802 ns/iter	824.7733326267225 ns/iter	1.00

This comment was automatically generated by workflow using github-action-benchmark.