Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roles: add service-level Workspaces service admin role #83

Merged
merged 1 commit into from
Jan 15, 2025
Merged

roles: add service-level Workspaces service admin role #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions roles/roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,18 @@ var (
}
)

// services.Workspaces
var (
RoleWorkspacesServiceAdmin = ToRole(services.Workspaces, "service_admin")
workspacesRoles = []roleInfo{
{
id: RoleWorkspacesServiceAdmin,
service: services.Workspaces,
resourceType: Service,
},
}
)

var registeredRoles = func() []roleInfo {
var registered []roleInfo

Expand All @@ -138,6 +150,7 @@ var registeredRoles = func() []roleInfo {
appendRoles(dotcomRoles)
appendRoles(sscRoles)
appendRoles(enterprisePortalRoles)
appendRoles(workspacesRoles)
// 👉 ADD YOUR ROLES HERE

return registered
Expand Down
8 changes: 4 additions & 4 deletions roles/roles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ func TestGoldenList(t *testing.T) {
got := List()
slices.Sort(got)
autogold.Expect([]Role{
Role("dotcom::site_admin"),
Role("enterprise_portal::customer_admin"),
Role("dotcom::site_admin"), Role("enterprise_portal::customer_admin"),
Role("ssc::admin"),
Role("workspaces::service_admin"),
}).Equal(t, got)
}

Expand Down Expand Up @@ -84,8 +84,8 @@ func TestRolesByResourceType(t *testing.T) {
name: "service",
resource: Service,
expected: autogold.Expect([]Role{
Role("dotcom::site_admin"),
Role("ssc::admin"),
Role("dotcom::site_admin"), Role("ssc::admin"),
Role("workspaces::service_admin"),
}),
},
{
Expand Down
Loading