Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roles: add service-level Workspaces service admin role #83

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

bobheadxi
Copy link
Member

Part of https://linear.app/sourcegraph/issue/CORE-363/workspaces-internal-trigger-to-suspendun-suspend-a-workspace - this will be used to gate access to the upcoming AdminstrationService for administering workspaces.

Test plan

CI

@bobheadxi bobheadxi requested a review from a team as a code owner January 15, 2025 22:25
@bobheadxi bobheadxi requested review from eseliger and jac January 15, 2025 22:26
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I find it slightly odd that you have to add a role that only exists in the service here, but just a random thought

@bobheadxi
Copy link
Member Author

I think I find it slightly odd that you have to add a role that only exists in the service here, but just a random thought

This is partly to make sure integrators hold it right, and to give us a central index of the available roles, similar to scopes

@bobheadxi bobheadxi merged commit 5aa59b4 into main Jan 15, 2025
2 checks passed
@bobheadxi bobheadxi deleted the roles-workspaces-service-admin branch January 15, 2025 23:16
@unknwon
Copy link
Member

unknwon commented Jan 16, 2025

Source code as a registry 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants