roles: refactor to support Resources #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
reviewed
Oct 30, 2024
bobheadxi
approved these changes
Oct 30, 2024
unknwon
reviewed
Nov 5, 2024
| return ParsedRole{}, false | ||
| } | ||
| // Display returns the display name of the resource type. | ||
| func (r ResourceType) Display() string { |
There was a problem hiding this comment.
nit: I think the conventional name of this method is DisplayName 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support roles at the resource level this refactors the sdk internals with a new
roleInfotype. From which the data can be transformed by helper methods to be used by SAMS + integrations.Previously roles were registered + exposed from the
AllowedRolesfunction.Registration has been split into an internal variable
registeredRolesfrom which public functions such asList,ByService,ByResourceType, etc. derive different views of the data.Test plan
CI