client/tokens: fix cache hit return (#77)

lol ## Test plan CI
sourcegraph · Nov 28, 2024 · 8ad5975 · 8ad5975
1 parent 8e3c388
commit 8ad5975
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/clientv1_tokens.go b/clientv1_tokens.go
@@ -51,7 +51,9 @@ type IntrospectTokenResponse struct {
 // `.Active == false`.
 func (s *TokensServiceV1) IntrospectToken(ctx context.Context, token string) (*IntrospectTokenResponse, error) {
 	if s.introspectTokenCache != nil {
-		if cached, ok := s.introspectTokenCache.Get(token); ok && cached.ExpiresAt.Before(time.Now()) {
+		if cached, ok := s.introspectTokenCache.Get(token); ok && // entry exists
+			// and NOT expired
+			cached.ExpiresAt.After(time.Now()) {
 			trace.SpanFromContext(ctx).
 				SetAttributes(attribute.Bool("sams.introspectToken.fromCache", true))
 			return cached, nil