Autocomplete compatibility fix part 2 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft.VisualStudio.Language v17.6.268 - StreamJsonRpc was automatically added as dependency after referencing VisualStudio.Language
…on doesn't support Microsoft.VisualStudio.Language library: - Autocomplete code moved to Cody.VisualStudio.Completions project, loaded as independent dll when VS starts - main Cody.VisualStudio.dll is loaded separately by VS - Cody.VisualStudio.Completions.dll is loaded as separated Mef dll (vsixmanifest changes) - Cody.VisualStudio.Completions.dll is automatically packaged to VSIX installer (Cody.VisualStudio.csproj changes) - Cody.VisualStudio project doesn't have dependency on Microsoft.VisualStudio.Language (no more crashes when Microsoft.VisualStudio.Language is not supported by specific VS version)
…alStudio.csproj - error MSB4006: There is a circular dependency in the target dependency graph involving target "ResolveProjectReferences". [\src\Cody.VisualStudio.Completions\Cody.VisualStudio.Completions.csproj]
PiotrKarczmarz
force-pushed
the
piotr/autocomplete-loaded-independently-via-mef
branch
from
f2d222f to
c4cc7d9
Compare
PiotrKarczmarz
deleted the
piotr/autocomplete-loaded-independently-via-mef
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete loads and initialize via MEF independently from the main extension. It allows to avoid extension crashes in Visual Studio versions below 17.6, which doesn't support using
Microsoft.VisualStudio.Languagelibrary, more preciselyMicrosoft.VisualStudio.Threadingv17.6 (check #198).If the current VS version supports
Microsoft.VisualStudio.Language,Cody.VisualStudio.Completions.dllwill be silently loaded via MEF. Otherwise,Cody.VisualStudio.Completions.dllwon't be loaded, but the main extension will be working.In the future, if Visual Studio will introduce breaking changes to Microsoft.VisualStudio.Language API, the main extension with chat will still be working, but autocomplete will be silently turned off.
It was tested against VS versions:
17.7.6
17.9 Preview 2
17.10.3
17.12
17.13.0 Preview 2.1
Test plan
Test autocomplete using your current VS version, and others if they are available.