Autocomplete #166
Autocomplete #166
Conversation
| @@ -55,10 +55,10 @@ public sealed partial class CodyPackage : AsyncPackage | |||
| public ILog AgentLogger; | |||
| public ILog AgentNotificationsLogger; | |||
|
|
|||
| public static IAgentService AgentService; | |||
| public static IUserSettingsService UserSettingsService; | |||
There was a problem hiding this comment.
Is there any specific reason why static is used for UserSettingsService?
There was a problem hiding this comment.
In GeneralOptionsPage constructor let's use:
_logger = _codyPackage.Logger;
_settingsService = _codyPackage.UserSettingsService
and remove static from CodyPackage property:
public IUserSettingsService UserSettingsService;
There was a problem hiding this comment.
These services must be available to multiple instances of CodyProposalSource and CodyProposalSourceProvider and their initialization time is set by MEF. By making them static we are ensured easy access to these services from instances of Proposal classes.
There was a problem hiding this comment.
Ahh, ok, make sense. I forgot that UserSettingsService is used in the CodyProposalSource.
Let's only revert changes in GeneralOptionsPage to have consistent use there:
_logger = _codyPackage.Logger;
_settingsService = _codyPackage.UserSettingsService
We know that UserSettingsService is static, but let's assume only autocomplete related classed can use it explicitly.
Tabkeyboard press (lalt+,for rotating suggestions if there is more than one)lalt+.)Test plan
TabEsc