Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly walk from atypically named top files using the target path #183

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Correctly walk from atypically named top files using the target path #183

merged 3 commits into from
Dec 16, 2023

Conversation

sourcefrog
Copy link
Owner

@sourcefrog sourcefrog commented Dec 11, 2023 •
edited
Loading

Remember whether the file is a target top, rather than relying on the file name.

Fixes #115

  • Tests with a Cargo.toml using the target path feature

@sourcefrog
Correctly walk from atypically named top files
62eca26 
Remember whether the file is a target top, rather than
relying on the file name.

Fixes #115
but needs tests
@sourcefrog sourcefrog linked an issue Dec 11, 2023 that may be closed by this pull request
fails to traverse from mod foo to foo.rs in some cases #115
Closed
@sourcefrog sourcefrog mentioned this pull request Dec 15, 2023
Closed
@sourcefrog sourcefrog changed the title Correctly walk from atypically named top files Correctly walk from atypically named top files using the target path Dec 16, 2023
@sourcefrog sourcefrog marked this pull request as ready for review December 16, 2023 21:12
@sourcefrog sourcefrog enabled auto-merge December 16, 2023 21:14
@sourcefrog sourcefrog merged commit 1d1459f into main Dec 16, 2023
11 checks passed
@sourcefrog sourcefrog deleted the 115-mod-not-found branch December 16, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fails to traverse from mod foo to foo.rs in some cases
1 participant
@sourcefrog