Merge pull request backstage#8143 from backstage/freben/await-error

Fixed missing `await` when throwing server side errors
soprasteria · Nov 18, 2021 · 153eac4 · 153eac4
2 parents ddfdcd2 + 9f21236
commit 153eac4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/sharp-carrots-press.md b/.changeset/sharp-carrots-press.md
@@ -0,0 +1,6 @@
+---
+'@backstage/plugin-config-schema': patch
+'@backstage/plugin-scaffolder': patch
+---
+
+Fixed a missing `await` when throwing server side errors
diff --git a/plugins/config-schema/src/api/StaticSchemaLoader.ts b/plugins/config-schema/src/api/StaticSchemaLoader.ts
@@ -49,7 +49,7 @@ export class StaticSchemaLoader implements ConfigSchemaApi {
         return undefined;
       }
 
-      throw ResponseError.fromResponse(res);
+      throw await ResponseError.fromResponse(res);
     }
 
     return await res.json();

diff --git a/plugins/scaffolder/src/api.ts b/plugins/scaffolder/src/api.ts
@@ -187,7 +187,7 @@ export class ScaffolderClient implements ScaffolderApi {
     });
 
     if (!response.ok) {
-      throw ResponseError.fromResponse(response);
+      throw await ResponseError.fromResponse(response);
     }
 
     return await response.json();
@@ -302,7 +302,7 @@ export class ScaffolderClient implements ScaffolderApi {
     });
 
     if (!response.ok) {
-      throw ResponseError.fromResponse(response);
+      throw await ResponseError.fromResponse(response);
     }
 
     return await response.json();