Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS-12 Bug Fix: Stop resource events being sent to control clients #437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IS-12 Bug Fix: Stop resource events being sent to control clients #437

wants to merge 1 commit into from

Conversation

jonathan-r-thorpe
Copy link
Contributor

  • IS-12 re-uses the data grain subscription mechanism for sending notifications to IS-12 Clients
  • A side effect (bug) is that any resource events generated, for instance by deleting an NMOS resource, are also sent to the IS-12 Client
  • This is unexpected as IS-12 Clients are only expecting IS-12 notifications
  • Bug fix ignores resource events in the control protocol WebSocket subscription handling
  • This raises the question: could IS-12 notifications be inadvertently sent over IS-07 event and tally WebSocket when both are in use?

@jonathan-r-thorpe
Only send control events to the control client
cd9581d 
(cherry picked from commit 5f205b6811567ab8d92651ae0d549da1d18eb92c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathan-r-thorpe