Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip NVGRE hash tests for Broadcom SKUs #16888

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

kperumalbfn
Copy link
Contributor

Description of PR

To skip NVGRE hash tests for Broadcom SKUs

Approach

What is the motivation for this PR?

With the default hash algorithm, NVGRE hash test fails for Broadcom SKUs, so skip.

How did you do it?

Check for the asic_type and skip for Broadcom SKUs.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to skip using tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn
Copy link
Contributor Author

Suggest to skip using tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

Thanks, Done

Copy link
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@bingwang-ms bingwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit b5589e8 into sonic-net:master Feb 11, 2025
18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 11, 2025
* Skip NVGRE hash tests for Broadcom SKUs

* Review comments
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16911

mssonicbld pushed a commit that referenced this pull request Feb 12, 2025
* Skip NVGRE hash tests for Broadcom SKUs

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants