Kubernetes 1.31 and go1.23 #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
upgrade k8s k8s and go upgrade gen wip prevent duplicate controller registration errors
tjons
force-pushed
the
tjons/k8s-1.31
branch
from
bc34d5d to
2631103
Compare
|
Issues linked to changelog: |
puertomontt
previously approved these changes
Sep 10, 2024
sam-heilbron
approved these changes
Sep 10, 2024
| @@ -37,6 +39,13 @@ func MustManager(ctx context.Context, ns string) manager.Manager { | |||
| Cache: cache.Options{ | |||
| DefaultNamespaces: map[string]cache.Config{ns: cache.Config{}}, | |||
| }, | |||
| Controller: config.Controller{ | |||
There was a problem hiding this comment.
I could ❤️ this comment any more. Super useful to have the c-r issue, and the rationale for why we skip it
puertomontt
approved these changes
Sep 10, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades our kubernetes dependencies to v1.31, and upgrades our golang version to 1.23.1.
Context
The
"k8s.io/client-go/util/workqueue"package has deprecated theworkqueue.RateLimiterInterfacetype in favor of a generic type, so that is the bulk of the code changes. The changes here (https://github.com/solo-io/skv2/pull/584/files#diff-db74ca5e769dd8b6314512f2a0ffb0532831ac381c2dcef8c3924cee208f9f63R42) are due to a new package level register for globally unique controllers that does not reset when a controller is removed. To allow our tests to run as desired, we disable unique name validation in the test suite.BOT NOTES:
resolves solo-io/gloo#9683