Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v1.16.x to Go 1.23 #10645

Open
wants to merge 2 commits into
base: v1.16.x
Choose a base branch
from
Open

Upgrade v1.16.x to Go 1.23 #10645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9932d6b
Updating to Go 1.23.3
ryanrolds Feb 20, 2025
7c5966b
Moving changelog into the correct dir
ryanrolds Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/v1.16.24/go-123.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
changelog:
- type: DEPENDENCY_BUMP
description: Bumped the go version to 1.23.3
dependencyOwner: golang
dependencyRepo: go
dependencyTag: v1.23.3
issueLink: https://github.com/solo-io/solo-projects/issues/7609
resolvesIssue: false
8 changes: 4 additions & 4 deletions ci/cloudbuild/publish-artifacts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
steps:

- name: 'gcr.io/$PROJECT_ID/prepare-go-workspace:0.8.8'
- name: 'gcr.io/$PROJECT_ID/prepare-go-workspace:0.10.2'
id: 'prepare-workspace'
args:
- '--repo-name'
Expand Down Expand Up @@ -44,7 +44,7 @@ steps:
- 'us-central1-a'

# Run make targets to push docker images to quay.io
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.8.8'
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.10.2'
id: 'publish-docker'
args:
- 'publish-docker'
Expand All @@ -65,7 +65,7 @@ steps:
waitFor:
- 'publish-docker'

- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.8.8'
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.10.2'
id: 'release-chart'
dir: *dir
args:
Expand All @@ -80,7 +80,7 @@ steps:
- 'gcr-auth'

# Run make targets to retag and push docker images to GCR
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.8.8'
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.10.2'
id: 'docker-push-extended-gcr'
dir: *dir
args:
Expand Down
12 changes: 6 additions & 6 deletions ci/cloudbuild/run-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
steps:

- name: 'gcr.io/$PROJECT_ID/prepare-go-workspace:0.8.8'
- name: 'gcr.io/$PROJECT_ID/prepare-go-workspace:0.10.2'
id: 'prepare-workspace'
args:
- '--repo-name'
Expand All @@ -23,7 +23,7 @@ steps:
cd /go/pkg
gsutil cat gs://$PROJECT_ID-cache/gloo/gloo-mod.tar.gz | tar -xzf - || echo "untar mod cache failed; continuing because we can download deps as we need them"

- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.8.8'
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.10.2'
id: 'prepare-envoy'
dir: *dir
entrypoint: 'bash'
Expand Down Expand Up @@ -74,7 +74,7 @@ steps:
waitFor:
- 'prepare-gcr-zone'

- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.8.8'
- name: 'gcr.io/$PROJECT_ID/go-mod-make:0.10.2'
id: 'prepare-test-tools'
dir: *dir
args:
Expand All @@ -85,7 +85,7 @@ steps:
- 'prepare-gcr-zone'
- 'prepare-test-credentials'

- name: 'gcr.io/$PROJECT_ID/e2e-go-mod-ginkgo:0.8.8'
- name: 'gcr.io/$PROJECT_ID/e2e-go-mod-ginkgo:0.10.2'
id: 'run-tests'
dir: *dir
entrypoint: 'make'
Expand All @@ -96,7 +96,7 @@ steps:
secretEnv:
- 'JWT_PRIVATE_KEY'

- name: 'gcr.io/$PROJECT_ID/e2e-go-mod-ginkgo:0.8.8'
- name: 'gcr.io/$PROJECT_ID/e2e-go-mod-ginkgo:0.10.2'
id: 'run-e2e-tests'
dir: *dir
entrypoint: 'make'
Expand All @@ -107,7 +107,7 @@ steps:
secretEnv:
- 'JWT_PRIVATE_KEY'

- name: 'gcr.io/$PROJECT_ID/e2e-go-mod-ginkgo:0.8.8'
- name: 'gcr.io/$PROJECT_ID/e2e-go-mod-ginkgo:0.10.2'
id: 'run-hashicorp-e2e-tests'
dir: *dir
entrypoint: 'make'
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild-cache.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
options:
env:
- "_GO_VERSION=1.21.5"
- "_GO_VERSION=1.23.3"

steps:
- name: gcr.io/cloud-builders/gsutil
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/solo-io/gloo

go 1.21.11
go 1.23.3

// Note for developers: upgrading go will also require upgrading go in the following files:
// ./cloudbuild-cache.yaml,
Expand Down