Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static-analysis.yaml #10623

Closed
wants to merge 3 commits into from
Closed

Update static-analysis.yaml #10623

wants to merge 3 commits into from

Conversation

sheidkamp
Copy link

@sheidkamp sheidkamp commented Feb 17, 2025

Description

Pin golangci-lint-action to 6.4.1 to avoid breaking changes in 6.5.0

Copy link

github-actions bot commented Feb 17, 2025

Visit the preview URL for this PR (updated for commit 7c9ad5f):

https://gloo-edge--pr10623-sheidkamp-lint-chang-hixgq7zd.web.app

(expires Mon, 24 Feb 2025 17:38:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@sheidkamp
Copy link
Author

/kick

Copy link

@arianaw66 arianaw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- type: NON_USER_FACING
resolvesIssue: false
description: >-
Pin golangci-lint-action to `6.4.1` to avoid breaking changes in `6.5.0`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intend to update as part of this work/soon in the future and this is a temp fix, or 6.4 is the plan longer-term?

@sheidkamp
Copy link
Author

Updating config instead, #10625

@sheidkamp sheidkamp closed this Feb 17, 2025
@sheidkamp sheidkamp deleted the sheidkamp/lint-changes branch February 18, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants