Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.24, linter update, and resolve linter/vet issues #10620

Merged
merged 32 commits into from
Feb 20, 2025
Merged

Go 1.24, linter update, and resolve linter/vet issues #10620

merged 32 commits into from
Feb 20, 2025

Conversation

ryanrolds
Copy link

@ryanrolds ryanrolds commented Feb 14, 2025 •
edited
Loading

Description

Upgrade to Go 1.24. Required updating golangci-lint. Resolves linter and go vet issues.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@ryanrolds ryanrolds changed the title Go 1.24 Go 1.24, linter update, and resolve linter/vet issues Feb 18, 2025
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7609

@ryanrolds ryanrolds marked this pull request as ready for review February 19, 2025 15:11
@ryanrolds ryanrolds requested a review from a team as a code owner February 19, 2025 15:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 52f2a1d):

https://gloo-edge--pr10620-rolds-go-124-lt82j4sn.web.app

(expires Thu, 27 Feb 2025 21:50:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@soloio-bulldozer soloio-bulldozer bot merged commit 52a70ed into main Feb 20, 2025
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the rolds/go_124 branch February 20, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-heilbron sam-heilbron sam-heilbron approved these changes

@nfuden nfuden nfuden approved these changes

Assignees
No one assigned
Labels
keep pr updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanrolds @sam-heilbron @nfuden