Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.17] fix: gwp does not respect image variant #10605

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

davidjumani
Copy link

Description

Backport of #10603

Ensures the images generated in the gatewayparams via helm respect the global.image.variant

Context

https://github.com/solo-io/solo-projects/issues/7803

Testing steps

Before :

helm-template-oss --set kubeGateway.enabled=true --set global.image.variant=fips-distroless

# Source: gloo/templates/43-gatewayparameters.yaml
kind: GatewayParameters
...
    sdsContainer:
      image:
        registry: quay.io/solo-io
        repository: sds-ee
        tag: 1.0.0-ci1

After :

helm-template-oss --set kubeGateway.enabled=true --set global.image.variant=fips-distroless

# Source: gloo/templates/43-gatewayparameters.yaml
kind: GatewayParameters
...
    sdsContainer:
      image:
        registry: quay.io/solo-io
        repository: sds-ee-fips
        tag: 1.0.0-ci1-distroless

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/gloo/issues/10602

@davidjumani davidjumani changed the title fix: gwp does not respect image variant (#10603) [1.17] fix: gwp does not respect image variant Feb 11, 2025
@soloio-bulldozer soloio-bulldozer bot merged commit d7870f4 into v1.17.x Feb 11, 2025
18 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the fix-gwp-fips-distroless-117 branch February 11, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants