Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Potentially fix flaky ValidtionStrict test #10598

Closed
wants to merge 1 commit into from

Conversation

davidjumani
Copy link

Description

Potentially fix the flaky ValidationStrct test by ensuring the kubeCoreFailurePolicy is set to Fail

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

github-actions bot commented Feb 6, 2025

Visit the preview URL for this PR (updated for commit ee6e317):

https://gloo-edge--pr10598-fix-validation-stric-5racicqj.web.app

(expires Thu, 13 Feb 2025 19:14:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Copy link

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that flakes can be hard to pin down, and thus prove that they are resolved, so at times we take a bet and then view the results.

Can you share some insight into what the flake is, what we suspect is happening and why this change is expected to have an impact?
Additionally, how will we validate this change? Even if it's just "well check back in on results in 2 weeks" I can live with that

@davidjumani davidjumani closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants