tests: Potentially fix flaky TestConfigureNotAttachedHttpListenerOptions #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
ryanrolds
approved these changes
Jan 31, 2025
shashankram
approved these changes
Jan 31, 2025
|
Visit the preview URL for this PR (updated for commit 1de1502): https://gloo-edge--pr10596-fix-http-listener-fl-7gt3rtlr.web.app (expires Fri, 07 Feb 2025 17:26:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potentially fixes the TestConfigureNotAttachedHttpListenerOptions flake. It was noticed that the second test generally took longer to run since the inital connections to the proxy would fail. This could be because the proxy does not come up in time or the DNS cache became out of date, and we would curl the old IP
Similar to 5b41985
Code changes
Ensure the gateway is created once rather than every test as it is common across tests
Context
#10594
Testing steps
Verified that both tests in the suite take the same time to execute which does partially (?) validate the solution
BOT NOTES:
resolves #10594