Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump logs for all containers when test fails #10573

Merged

Conversation

andy-fong
Copy link

@andy-fong andy-fong commented Jan 15, 2025

Description

  • previously setting --all-containers does not seem to work. --all-containers=true works
  • also added --prefix=true to add pod/container_name prefix to the log lines
  • this only affects the artifacts we upload when test fails

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • [/] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@soloio-bulldozer soloio-bulldozer bot merged commit 65196f5 into main Jan 15, 2025
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the andyfong-dump-logs-for-all-containers-on-test-fail branch January 15, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants