Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable performance tests #10425

Closed
wants to merge 13 commits into from
Closed

Conversation

npolshakova
Copy link

@npolshakova npolshakova commented Dec 2, 2024

Description

Disable performance tests in OSS.

API changes

NONE

Code changes

NONE

CI changes

  • Disable automatic nightly performance tests
  • Keep manual CI performance trigger, but bump image
  • Add instructions for running performance tests locally.

Docs changes

NONE

Context

kgateway-dev#10369 (comment)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves kgateway-dev#10369

@solo-changelog-bot
Copy link

Issues linked to changelog:
kgateway-dev#10369

Copy link

github-actions bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit 9bd755b):

https://gloo-edge--pr10425-npolshak-disable-per-4rtq5fno.web.app

(expires Mon, 09 Dec 2024 20:55:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

[ProxyReport](https://github.com/solo-io/gloo/blob/1f457f4ef5f32aedabc58ef164aeea92acbf481e/projects/gloo/pkg/api/grpc/validation/gloo_validation.pb.go#L837) is an aggregated set of reports for all sub-resources of a Proxy.

## Performance Tests
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions on how to still run performance tests?

@npolshakova
Copy link
Author

Closing in favor of #10535 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove performance tests
1 participant