-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: propagate eds changes when annotations change. #10411
Conversation
As the lb hash propagates to EndpointsVersion, it needs to include cluster name as well, until we hopfully stop appending upstream hashes to cluster names soon
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit 596641d): https://gloo-edge--pr10411-yuval-k-annotate-svc-ulxjd139.web.app (expires Wed, 04 Dec 2024 15:48:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth it to add an e2e test to ensure this doesn't regress in the future since it's a core piece of functionality?
We agreed that an e2e test would be valuable. However, this PR fixes the bug and disables a very flakey test. So our plan is:
|
As the lb hash propagates to EndpointsVersion, it needs to include cluster name as well, until we hopfully stop appending upstream hashes to cluster names soon
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7301