Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: propagate eds changes when annotations change. #10411

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

yuval-k
Copy link
Member

@yuval-k yuval-k commented Nov 26, 2024

As the lb hash propagates to EndpointsVersion, it needs to include cluster name as well, until we hopfully stop appending upstream hashes to cluster names soon

BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7301

As the lb hash propagates to EndpointsVersion, it needs to include cluster name as well, until we hopfully stop appending upstream hashes to cluster names soon
@yuval-k yuval-k marked this pull request as ready for review November 27, 2024 02:01
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7301

Copy link

github-actions bot commented Nov 27, 2024

Visit the preview URL for this PR (updated for commit 596641d):

https://gloo-edge--pr10411-yuval-k-annotate-svc-ulxjd139.web.app

(expires Wed, 04 Dec 2024 15:48:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Copy link

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth it to add an e2e test to ensure this doesn't regress in the future since it's a core piece of functionality?

@sam-heilbron
Copy link

Do you think it's worth it to add an e2e test to ensure this doesn't regress in the future since it's a core piece of functionality?

We agreed that an e2e test would be valuable. However, this PR fixes the bug and disables a very flakey test. So our plan is:

  • Yuval will merge this code as is, without an e2e test
  • Yuval will work on fixing the flaky test
  • Sam/Yuval will pair on writing an e2e test

@soloio-bulldozer soloio-bulldozer bot merged commit da0f35a into main Nov 27, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the yuval-k/annotate-svc branch November 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants