attempt to deflake ggv2 setup test #10410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the gateway; with that in mind, added retries to fetching xds snapshots
|
Visit the preview URL for this PR (updated for commit 645bc26): https://gloo-edge--pr10410-yuval-k-defalt-test-b2f5cuq1.web.app (expires Mon, 09 Dec 2024 15:44:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
note: this PR cannot go in with this change, we need to disable MarshalJSON by renaming it
sam-heilbron
approved these changes
Nov 30, 2024
nfuden
approved these changes
Dec 2, 2024
kevin-shelaga
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looking at the krt snapshot from the new logs, we can see the client hasn't connected to the gateway; with that in mind, added retries to fetching xds snapshots