Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: do not add work in progress label by default #10407

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

sam-heilbron
Copy link

Description

Reverts the work in kgateway-dev#9849

Context

A number of slack threads opened by engineers about how this is confusing and leads to toil.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

@andy-fong andy-fong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like the label being added automatically but I am ok either. Are we going to do the same for solo-projects? I know in solo-projects, the work in progress labels also prevent the regession tests from running.

@sam-heilbron
Copy link
Author

/skip-ci non-functional change

@soloio-bulldozer soloio-bulldozer bot merged commit 0d40c8e into main Nov 26, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/work-in-progress-default-false branch November 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants